Do not leak running pools from the internal collection #3885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In theory the
ThreadPoolManager
could leak running thread pools an create new ones.I have not seen this in the wild, but it could happen.
The
ThreadPoolManager
did use aWeakHashMap<String, ExecutorService>
to store the running pools.It holds a weak reference to the
String
and a strong to theExecutorService
.As soon as the
String
gets collected by the GC, the strong reference to theExecutorService
is dopped.This is a example of problematic code, this could create two pools when GC did clear the
WeakReferences
between the two calls toThreadPoolManager.getScheduledPoolUnwrapped
:Beside this, there are other issues like accessing the
WeakHashMap
outside a synchronized block.This double check logic used is in my mind only safe for immutable objects...
Description
This PR will replace the
WeakHashMap
with aConcurrentHashMap
to fix the issues above.