[addonInfo extensions] adopt reviewer suggestions

Signed-off-by: Andrew Fiddian-Green <[email protected]>
openhab · Dec 5, 2023 · d249146 · d249146
1 parent 164187c
commit d249146
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/bundles/org.openhab.core.addon/src/main/java/org/openhab/core/addon/AddonInfoRegistry.java b/bundles/org.openhab.core.addon/src/main/java/org/openhab/core/addon/AddonInfoRegistry.java
@@ -43,7 +43,7 @@ public class AddonInfoRegistry {
     private final Collection<AddonInfoProvider> addonInfoProviders = new CopyOnWriteArrayList<>();
 
     @Reference(cardinality = ReferenceCardinality.MULTIPLE, policy = ReferencePolicy.DYNAMIC)
-    public void addAddonInfoProvider(AddonInfoProvider addonInfoProvider) {
+    protected void addAddonInfoProvider(AddonInfoProvider addonInfoProvider) {
         addonInfoProviders.add(addonInfoProvider);
     }
 

diff --git a/...e/addon/test/AddonInfoListReaderTest.java → ...b/core/addon/AddonInfoListReaderTest.java b/...e/addon/test/AddonInfoListReaderTest.java → ...b/core/addon/AddonInfoListReaderTest.java
@@ -10,7 +10,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0
  */
-package org.openhab.core.addon.test;
+package org.openhab.core.addon;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -21,10 +21,6 @@
 
 import org.eclipse.jdt.annotation.NonNullByDefault;
 import org.junit.jupiter.api.Test;
-import org.openhab.core.addon.AddonDiscoveryMethod;
-import org.openhab.core.addon.AddonInfo;
-import org.openhab.core.addon.AddonInfoList;
-import org.openhab.core.addon.AddonMatchProperty;
 import org.openhab.core.addon.internal.xml.AddonInfoListReader;
 
 /**

diff --git a/...ddon/test/AddonInfoRegistryMergeTest.java → ...ore/addon/AddonInfoRegistryMergeTest.java b/...ddon/test/AddonInfoRegistryMergeTest.java → ...ore/addon/AddonInfoRegistryMergeTest.java
@@ -10,7 +10,7 @@
  *
  * SPDX-License-Identifier: EPL-2.0
  */
-package org.openhab.core.addon.test;
+package org.openhab.core.addon;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
@@ -33,11 +33,6 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.TestInstance;
 import org.junit.jupiter.api.TestInstance.Lifecycle;
-import org.openhab.core.addon.AddonDiscoveryMethod;
-import org.openhab.core.addon.AddonInfo;
-import org.openhab.core.addon.AddonInfoProvider;
-import org.openhab.core.addon.AddonInfoRegistry;
-import org.openhab.core.addon.AddonMatchProperty;
 
 /**
  * JUnit test for the {@link AddonInfoRegistry} merge function.