Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Karaf from 4.4.6 to 4.4.7 #17515

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Upgrade Karaf from 4.4.6 to 4.4.7 #17515

merged 2 commits into from
Jan 26, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Oct 6, 2024 •
edited
Loading

Depends on Karaf 4.4.7 upgrade of core, openhab/openhab-core#4406.
I updated a few commons libs in the addons as well to keep it in sync with core. Hope this does not break something.

  • Sync runtime dependencies with Karaf 4.4.7, most notably:
    • PaxWeb 8.0.30
    • Jetty 9.4.57.v20241219
    • BouncyCastle 1.78.1
    • CXF 3.6.4
    • Jackson 2.18.2
    • JNA 5.16.0
    • JAXB 2.3.9
    • commons-io 2.17.0
    • commons-lang3 3.17.0
    • commons-logging 1.3.4
    • ASM 9.7.1
    • PaxLogging 2.2.8
  • Resolve itest runbundles
  • Adapt to core change, xtext dependencies
    • gson 2.11.0
    • guava 3.33.1
    • ecj 3.39.0
    • Fix newly introduced compilation and test issues in bindings

@holgerfriedrich holgerfriedrich added awaiting external dependency Depends on a new version of an external dependency work in progress A PR that is not yet ready to be merged labels Oct 6, 2024
@lsiepel lsiepel mentioned this pull request Oct 6, 2024
Merged
@holgerfriedrich holgerfriedrich force-pushed the k447 branch 3 times, most recently from 237c2d7 to b4060b5 Compare November 6, 2024 23:07
david-pace
david-pace approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for boschshc 👍

ccutrer
ccutrer approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@ccutrer ccutrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for mqtt.homeassistant and jinja

@holgerfriedrich holgerfriedrich force-pushed the k447 branch 2 times, most recently from 610ab0c to 4c56e22 Compare December 3, 2024 21:25
@holgerfriedrich holgerfriedrich force-pushed the k447 branch 3 times, most recently from 4d19097 to 6c053c7 Compare January 7, 2025 21:56
david-pace
david-pace requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an assertion that should be slightly adapted in our boschshc tests.

.../src/test/java/org/openhab/binding/boschshc/internal/devices/bridge/BoschHttpClientTest.java Outdated Show resolved Hide resolved
@holgerfriedrich
Upgrade Karaf from 4.4.6 to 4.4.7
75f76cc 
* Sync runtime dependencies with Karaf 4.4.7, most notably:
   * PaxWeb 8.0.30
   * Jetty 9.4.57.v20241219
   * BouncyCastle 1.78.1
   * CXF 3.6.4
   * Jackson 2.18.2
   * JNA 5.16.0
   * JAXB 2.3.9
   * commons-io 2.17.0
   * commons-lang3 3.17.0
   * commons-logging 1.3.4
   * ASM 9.7.1
   * PaxLogging 2.2.8
 * Resolve itest runbundles

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich
Adapt to core change, xtext dependencies
20ee793 
* gson 2.11.0
* guava 3.33.1
* ecj 3.39.0
* Fix newly introduced compilation and test issues in bindings

Signed-off-by: Holger Friedrich <[email protected]>
@holgerfriedrich holgerfriedrich added awaiting other PR Depends on another PR and removed work in progress A PR that is not yet ready to be merged awaiting external dependency Depends on a new version of an external dependency labels Jan 24, 2025
@holgerfriedrich holgerfriedrich changed the title [WIP] Upgrade Karaf from 4.4.6 to 4.4.7 Upgrade Karaf from 4.4.6 to 4.4.7 Jan 24, 2025
david-pace
david-pace approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@david-pace david-pace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for enhancing the unit test, looks good for boschshc 👍

@wborn wborn removed the awaiting other PR Depends on another PR label Jan 26, 2025
@wborn wborn merged commit f479a38 into openhab:main Jan 26, 2025
1 of 2 checks passed
@wborn wborn added this to the 5.0 milestone Jan 26, 2025
@holgerfriedrich holgerfriedrich deleted the k447 branch January 26, 2025 14:48
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh-5-0-snapshot-builds-failing/162137/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@david-pace david-pace david-pace approved these changes

@ccutrer ccutrer ccutrer approved these changes

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@peuter peuter Awaiting requested review from peuter peuter is a code owner

@J-N-K J-N-K Awaiting requested review from J-N-K J-N-K is a code owner

@jochen314 jochen314 Awaiting requested review from jochen314 jochen314 is a code owner

@GerdZanker GerdZanker Awaiting requested review from GerdZanker GerdZanker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@holgerfriedrich @openhab-bot @ccutrer @david-pace @wborn