Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ private void getSubtestResult(Model model, NodeList testcallList, NodeList logLi
if (cFailCount > 0 || cInheritedFailureCount > 0) {
areCoreConformanceClassesPassed = false;
}
// prevent passing of basic conformance class with all tests skipped
// see https://github.com/opengeospatial/teamengine/issues/636
else if (cFailCount == 0 && cInheritedFailureCount == 0 && cPassCount == 0 && cSkipCount > 0) {
areCoreConformanceClassesPassed = false;
}
}
this.totalPassCount += cPassCount;
this.totalFailCount += cFailCount;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@
<xsl:when test="cite:testsFailed[text() !='0']">
<xsl:value-of select="'No'"/>
</xsl:when>
<xsl:when test="cite:testsFailed[text() ='0'] and cite:testsPassed[text() ='0'] and cite:testsSkipped[text() !='0']">
<xsl:value-of select="'No'"/>
</xsl:when>
<xsl:otherwise>
<xsl:value-of select="'Yes'"/>
</xsl:otherwise>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ void processSuiteResults(Model model, Map<String, ISuiteResult> results) {
if (nFailed > 0) {
areCoreConformanceClassesPassed = false;
}
// prevent passing of basic conformance class with all tests skipped
// see https://github.com/opengeospatial/teamengine/issues/636
else if (nFailed == 0 && nPassed == 0 && nSkipped > 0) {
areCoreConformanceClassesPassed = false;
}
}
processTestResults(model, testContext.getFailedTests());
processTestResults(model, testContext.getSkippedTests());
Expand Down