Adds onion map#4057
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds the "Onion" map end-to-end: two JSON map assets (info and manifest), registers ChangesOnion Map Addition
Sequence DiagramsequenceDiagram
participant MapGenerator
participant MapsRegistry
participant MapAssets
participant GameCore
participant PlaylistService
MapGenerator->>MapsRegistry: register "onion"
MapsRegistry->>MapAssets: load info.json & manifest.json
GameCore->>MapsRegistry: reference GameMapType.Onion
GameCore->>PlaylistService: include "Onion" via mapCategories
PlaylistService->>PlaylistService: set FREQUENCY["Onion"] = 2
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
If this PR fixes an issue, link it below. If not, delete these two lines.
Resolves #4055
Description:
Adds a 512*512 onion map with 3 nations (Leafer Confederation, Outer Enclave and Inner Tribe)
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tktk1234567