Skip to content

Fix disconnected Yalu River, KP/CN border#4056

Open
crunchybbb2 wants to merge 2 commits into
openfrontio:mainfrom
crunchybbb2:Korea-fix-northkorea-river
Open

Fix disconnected Yalu River, KP/CN border#4056
crunchybbb2 wants to merge 2 commits into
openfrontio:mainfrom
crunchybbb2:Korea-fix-northkorea-river

Conversation

@crunchybbb2
Copy link
Copy Markdown
Contributor

@crunchybbb2 crunchybbb2 commented May 28, 2026

Description:

Fixes a portion of the river on the Nk/cn border of the korea map that was disconnected from the ocean. Very minor fix

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME crunchybbbbb
image6767

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7f1dbde-ba51-4a44-8277-3cd8de48865a

📥 Commits

Reviewing files that changed from the base of the PR and between 98ea69b and 1970242.

📒 Files selected for processing (1)
  • resources/maps/korea/manifest.json
✅ Files skipped from review due to trivial changes (1)
  • resources/maps/korea/manifest.json

Walkthrough

The Korea map manifest updates only adjust num_land_tiles values for three map scales (map, map16x, map4x) in resources/maps/korea/manifest.json; no other fields changed.

Changes

Korea Map Manifest

Layer / File(s) Summary
Map tile count corrections
resources/maps/korea/manifest.json
num_land_tiles counts adjusted: map 1194108 → 1193914, map16x 71937 → 71922, map4x 294112 → 294064. Dimensions and other fields unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • evanpelle
  • RickD004

Poem

🗺️ Small numbers shift, the map stays true,
Three counts lowered, a tidy view.
Manifest whisper, quiet and neat,
Korea's tiles now line up neat. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix disconnected Yalu River, KP/CN border' directly relates to the changeset, which updates tile-count metadata for the Korea map to fix a disconnected river portion on the North Korea/China border.
Description check ✅ Passed The description explains that the PR fixes a disconnected river on the NK/CN border of the Korea map, which aligns with the tile-count adjustments made to the manifest.json file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants