Electron ^8.0.3 refactor (updated) - #240
Closed
Autr wants to merge 12 commits into
Closed
Conversation
added 12 commits
March 3, 2020 18:56
… ipcMain / ipcRenderer; remove path dependency / var name confusion; vars to lets / coasts; failsafes for defaultSettings; auto-guess OF root; remove redefined vars
Author
|
@arturoc ? |
|
Please merge this branch. It solved all my problems. |
Merged
Member
|
Thanks @Autr I was able to cut parts out and use for reference in new electron updates. Will look at adding addon defines or flags or project defines similar to yours, but for now addon_config.mk can handle this (for makefiles) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, referencing my last pull request 'ere:
#236
I left some big bugs open; refactoring the native file opening dialog. This is now fixed and there's also a compiled release for OSX in the fork for quick testing.