Skip to content

Remove redundant fga_client.close in python #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidroeca
Copy link

Description

fga_client.close() is handled by the context manager so it isn't needed, as discussed in openfga/python-sdk#191

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@davidroeca davidroeca requested a review from a team as a code owner May 8, 2025 21:56
Copy link

linux-foundation-easycla bot commented May 8, 2025

CLA Not Signed

@davidroeca
Copy link
Author

Please hold off on review. I'm realizing I still need to factor in changes from #116

@dyeam0
Copy link
Member

dyeam0 commented May 12, 2025

Please hold off on review. I'm realizing I still need to factor in changes from #116

Hi @davidroeca. While your refactoring and this PR is on hold, can you change it to Draft PR state? That helps with our tracking and makes the status more accurate. Thanks!

fga_client.close() is handled by the context manager so it isn't needed,
as discussed in openfga/python-sdk#191
@davidroeca davidroeca force-pushed the python-remove-redundant-close branch from f200d12 to 6826e93 Compare May 12, 2025 15:47
@davidroeca
Copy link
Author

Hi @dyeam0 that makes sense to me, but unfortunately I don't see a way to do so

image

@rhamzeh rhamzeh marked this pull request as draft May 12, 2025 17:28
@rhamzeh
Copy link
Member

rhamzeh commented May 12, 2025

@davidroeca (for next time) it's from the side bar
Screenshot 2025-05-12 at 1 28 45 PM

I marked it as draft for now - let us know when you believe is ready to review.

Also please make sure to sign the Linux Foundation's CLA (#545 (comment)) when you are ready for it to be merged. It's a one time process, and without it we're restricted from merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants