fix: use correct content type for token request #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2024
rhamzeh
approved these changes
Feb 12, 2024
github-merge-queue bot
pushed a commit
to openfga/dotnet-sdk
that referenced
this pull request
Feb 12, 2024
## Description Moves the client to use `application/x-www-form-urlencoded` for the content type when making token requests per the spec. In order to do this we needed to move from using `StringContent` to `FormUrlEncodedContent` and then the runtime will handle setting the content type header for us. Also syncs some changes from the sdk-generator repo. ## References Part of openfga/sdk-generator#284 Generated from openfga/sdk-generator#308 ## Review Checklist - [x] I have clicked on ["allow edits by maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork). - [ ] I have added documentation for new/changed functionality in this PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev) [Provide a link to any relevant PRs in the references section above] - [x] The correct base branch is being used, if not `main` - [ ] I have added tests to validate that the change in functionality is working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the remaining SDKs to use the correct content type when making a token request.
FormUrlEncodedContentas the body and then the runtime will handle setting theContent-Typefor usoauth2package we includedpost_paramsinstead of bodyThis has been verified by running all 4 examples and providing credentials, where possible tests have been amended to assert we're passing the right header/body.
References
Closes #284
Language PRs to follow
Review Checklist
main