Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All SDKS] Change OAuth2 credential request content type header to application/x-www-form-urlencoded #284

Closed
1 of 5 tasks
rhamzeh opened this issue Jan 26, 2024 · 0 comments · Fixed by #308
Closed
1 of 5 tasks
Assignees
Labels
bug Something isn't working dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK

Comments

@rhamzeh
Copy link
Member

rhamzeh commented Jan 26, 2024

As part of #255 we realized that while Auth0 supports both the JSON and application/x-www-form-urlencoded as the Content-Type of the Credential Flow request, the standard actually requires the latter, as pointed out by @nverbos-godaddy in openfga/java-sdk#47

We need to change the rest of the SDKs to use application/x-www-form-urlencoded

  • JS SDK
  • Go SDK
  • .NET SDK
  • Python SDK
  • Java SDK
@rhamzeh rhamzeh added bug Something isn't working go-sdk Affects the Go SDK dotnet-sdk Affects the C#/DotNet SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK java-sdk Affects the Java/Kotlin SDK labels Jan 26, 2024
@rhamzeh rhamzeh moved this to Ready in SDKs and Tooling Jan 26, 2024
@ewanharris ewanharris self-assigned this Feb 9, 2024
github-merge-queue bot pushed a commit to openfga/dotnet-sdk that referenced this issue Feb 12, 2024
## Description

Moves the client to use `application/x-www-form-urlencoded` for the
content type when making token requests per the spec.

In order to do this we needed to move from using `StringContent` to
`FormUrlEncodedContent` and then the runtime will handle setting the
content type header for us.

Also syncs some changes from the sdk-generator repo.

## References

Part of openfga/sdk-generator#284
Generated from openfga/sdk-generator#308

## Review Checklist
- [x] I have clicked on ["allow edits by
maintainers"](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork).
- [ ] I have added documentation for new/changed functionality in this
PR or in a PR to [openfga.dev](https://github.com/openfga/openfga.dev)
[Provide a link to any relevant PRs in the references section above]
- [x] The correct base branch is being used, if not `main`
- [ ] I have added tests to validate that the change in functionality is
working as expected
@github-project-automation github-project-automation bot moved this from Ready to Done in SDKs and Tooling Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dotnet-sdk Affects the C#/DotNet SDK go-sdk Affects the Go SDK java-sdk Affects the Java/Kotlin SDK js-sdk Affects the JavaScript SDK python-sdk Affects the Python SDK
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants