chore(docs): split Read examples in README to separate sections #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited README.md to create separate code blocks for Read Relationship Tuples example.
rhamzeh
requested changes
Jun 12, 2023
There was a problem hiding this comment.
Thanks @akj2018
You probably need to duplicate this part across all the code blocks:
response = await api_instance.read(body)
# response = ReadResponse({"tuples": [Tuple({"key": TupleKey({"user":"...","relation":"...","object":"..."}), "timestamp": datetime.fromisoformat("...") })]})
|
Also, looking at it now, the three above code blocks should read:
Mind doing that change too? |
rhamzeh
changed the title
…les (openfga#31) Edited README.md to create separate code blocks for Read Relationship Tuples example with following structure body = ReadRequest(...) response = await api_instance.read(body) response = ReadResponse({"tuples": [Tuple({"key": TupleKey({"user":"...","relation":"...","object":"..."}), "timestamp": datetime.fromisoformat("...") })]})
|
Hi @rhamzeh, thanks for letting me know. I have made the required changes in my latest commit. |
rhamzeh
approved these changes
Jun 13, 2023
adriantam
added a commit
to openfga/sdk-generator
that referenced
this pull request
Jun 22, 2023
Implement changes for openfga/python-sdk#32 and openfga/python-sdk#31
4 tasks
adriantam
added a commit
to openfga/sdk-generator
that referenced
this pull request
Jun 23, 2023
* fix(python-sdk): correct README Implement changes for openfga/python-sdk#32 and openfga/python-sdk#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Edited README.md to create separate code blocks for Read Relationship Tuples example.
References
OpenFGA RFC
Contributing to OpenFGA
Closes #26
Review Checklist
main