Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support assertions with context and contextual tuples #169

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

ewanharris
Copy link
Member

@ewanharris ewanharris commented Feb 6, 2025

Description

Adds Context and ContextualTuples support to Assertions in the OpenFGAClient

References

openfga/sdk-generator#449
openfga/api#185

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners February 6, 2025 14:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.78%. Comparing base (389d645) to head (946c053).

❌ Your project status has failed because the head coverage (25.78%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   25.73%   25.78%   +0.04%     
==========================================
  Files         104      104              
  Lines       12585    12593       +8     
==========================================
+ Hits         3239     3247       +8     
  Misses       9075     9075              
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewanharris ewanharris changed the title feat: support writing assertions with context and contextual tuples feat: support assertions with context and contextual tuples Feb 6, 2025
Copy link
Member

@aaguiarz aaguiarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it looks good to Ewan it looks good to me :)

@ewanharris ewanharris added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit ededd4a Feb 6, 2025
9 checks passed
@ewanharris ewanharris deleted the feat/add-contextual-tuples-to-assertions branch February 6, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants