Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new method to index.py to fix an issue with chunked encoding an… #10

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

ssullivan
Copy link
Contributor

@ssullivan ssullivan commented Oct 18, 2018

Fixes ISSUE #5

Description

Add a new method that changes some WSGI environ parameters to handle requests with chunked encoding.

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

I deployed the template as a function and invoked it using a browser based RESTClient to test sending requests with different kinds of content for their bodies. Before this change when I performed the same tests the request bodies in the handle method were always empty.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Oct 18, 2018

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off.
That's something we need before your Pull Request can be merged. Please see our contributing guide.

@derek derek bot added the no-dco label Oct 18, 2018
@ssullivan ssullivan force-pushed the bug/fix-encoding-problem branch from 00c7dd4 to 5c2608a Compare October 18, 2018 02:47
@derek derek bot removed the no-dco label Oct 18, 2018
Added new method to index.py to fix an issue with chunked
encoding and missing request bodies

Signed-off-by: Stephen Sullivan <[email protected]>
@ssullivan ssullivan force-pushed the bug/fix-encoding-problem branch from 5c2608a to 60b54f8 Compare October 18, 2018 02:52
@ssullivan
Copy link
Contributor Author

I believe this should be signed off now. I ran a git commit -amend -s to sign off but the bot didn’t re-run on the commit after pushing that change.

@alexellis
Copy link
Member

Sign-off worked, thank you.

@alexellis alexellis merged commit a64bdac into openfaas:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants