Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenFaaS on Nomad post #79

Closed
wants to merge 1 commit into from
Closed

Conversation

acornies
Copy link
Contributor

  • Post formatted in md format
  • Added supporting images

@acornies acornies changed the title [DRAFT] Initial nomad post commit: OpenFaaS on Nomad post Mar 18, 2019
@acornies
Copy link
Contributor Author

Addresses: #77

Copy link
Contributor

@ewilde ewilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @acornies really interesting blog post 👏 , Alex asked me to do a quick review. I've added some comments inline.


OpenFaaS providers are written in Golang, and it is easy to get started with your own backend using the [faas-provider library](https://github.com/openfaas/faas-provider). I had very little experience in Go prior to this project, so I quickly brushed up on some Golang fundamentals and started on some tasks. How hard could it be?

[![OpenFaaS Nomad and Vault Integration](http://img.youtube.com/vi/DObWEaO4etE/0.jpg)](http://www.youtube.com/watch?v=DObWEaO4etE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be useful to the reader to introduce this video, maybe quickly explain what they will get out of watching it?

Let's look at the Vault integration more closely:

### Vault faas-nomad startup arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be nice to list the pre-requisites for this to work. I'm guessing you need a nomad installation with vault and consul running before carrying out these steps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is assumes those 3 components are provisioned already. Good point.

```
Produces the secret_id needed for -vault_app_secret_id cli argument.

Let's assume the Vault parameters have been populated in the run args, and you're now running faas-nomad along with the other OpenFaaS components. Now, try out the new faas-cli secret commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe list how you would execute faas-nomad? Is this using a job specification in Nomad

@derek derek bot added the no-dco label May 27, 2019
@derek
Copy link

derek bot commented May 27, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

1 similar comment
@derek
Copy link

derek bot commented May 27, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --sign-off and then git push --force.

@alexellis
Copy link
Member

Hi @acornies, I really do need you to sign-off all your commits to be able to publish.

Unfortunately, this is going to delay the post going live. Please can you amend when you have a chance?

Alex

@acornies
Copy link
Contributor Author

acornies commented May 28, 2019

@alexellis, these commits are official Co-Authored commit messages from GitHub... Is this something we can improve with derek bot? The

I've just checked and your commit doesn't appear to be signed-off.

is misleading in this case.

- Original blog post content
- Included edits and suggestions from Ed
- updated provider diagram

Signed-off-by: Andrew Cornies <[email protected]>
@derek derek bot removed the no-dco label May 28, 2019
@alexellis alexellis mentioned this pull request Jun 3, 2019
@alexellis
Copy link
Member

Derek close: merged via #116

@derek derek bot closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants