fix: SCORM attachment link error #4144
Conversation
edalex-ian
changed the title
| commitUnzipPaths.foreach(p => stagingContext.moveFile(p._1, fa.getFilename)) | ||
| val UPLOADS_FOLDER = FileUploadState.UPLOADS_FOLDER | ||
| val newName = fa.getFilename.replaceFirst(s"^$UPLOADS_FOLDER/.*/", "") | ||
| stagingContext.moveFile(fa.getFilename, WebFileUploads.zipPath(newName)) |
There was a problem hiding this comment.
Can you add some comments here to describe why you do this ?
|
I imagine two things:
With that in mind, perhaps we should look back to how it used to be done, starting with the following references to when the change was made:
Keep in mind that since those the purscript code was replaced with typescript and the scala updated as needed. |
|
I found this bug was first mentioned in 2018 but I am confused since it said it was fixed. #576 |
|
Could it be because that change was not merged to develop? I can't find that commit history in develop branch locally. |
If you open any file involved in that commit, can you see the changes ? |
You can also try to cherry pick that commit in your working branch and see if it can fix the issue. |
|
That commit is not a merge commit. I think it was pushed to stable-6.6 directly. |
|
Work on this continues elsewhere, closing PR. |
Checklist
Description of change
Fix missing attachment links for unzip files.
The issue is in
stagingfolder all unzip files are not transferred properly and still stay in the folder_uploadswhich will be removed before moving toinstitutionfolder.#3465
Before:
Upload a zip file:
Unzip:
Save:
After fix
Upload zip file:
Unzip:
Save:
