fix: keep the edx_video_id for libraries - #293
Conversation
|
Thanks for the pull request, @AhtishamShahid! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Recreation of #282, which was blocked by a failing CLA check on the original author's commits. This PR re-applies the same change with commits authored under my (CLA-signed) account so the check can pass. All credit for the fix and tests belongs to @marslanabdulrauf.
Related Ticket
https://github.com/mitodl/hq/issues/12414 (MIT Internal)
Steps to reproduce the Issue:
Possible root cause:
For new runtime
edxval edx_video_idis being set to None which causes no sources to be loaded, which leads to this "No playable video sources found." error.Description
This pull request updates the handling of the
edx_video_idfield in theparse_xml_new_runtimemethod to improve video compatibility in content libraries. Instead of settingedx_video_idtoNone, the code now retains its value, ensuring that videos already present in the Video Asset Library (VAL) continue to work as expected.video.py: Updatedparse_xml_new_runtimeto retain theedx_video_idfield, preventing issues where videos become unplayable or lose their ID in the editor after saving.Merge checklist:
Check off if complete or not applicable: