Skip to content

fix: keep the edx_video_id for libraries - #293

Open
AhtishamShahid wants to merge 2 commits into
openedx:mainfrom
AhtishamShahid:ahtisham/12414-video-sources
Open

fix: keep the edx_video_id for libraries#293
AhtishamShahid wants to merge 2 commits into
openedx:mainfrom
AhtishamShahid:ahtisham/12414-video-sources

Conversation

@AhtishamShahid

Copy link
Copy Markdown
Contributor

Recreation of #282, which was blocked by a failing CLA check on the original author's commits. This PR re-applies the same change with commits authored under my (CLA-signed) account so the check can pass. All credit for the fix and tests belongs to @marslanabdulrauf.

Related Ticket

https://github.com/mitodl/hq/issues/12414 (MIT Internal)

Steps to reproduce the Issue:

  1. Get video id from course videos
  2. Create or go to any Library, add video component. Go to the video component, put the video id in and save (optionally publish)
  3. Click edit again and the "Video ID" is missing now.
  4. Strangely though you can see it in the "Advanced Details"
  5. And in the preview we get "No playable video source"

Possible root cause:

For new runtime edxval edx_video_id is being set to None which causes no sources to be loaded, which leads to this "No playable video sources found." error.

Description

This pull request updates the handling of the edx_video_id field in the parse_xml_new_runtime method to improve video compatibility in content libraries. Instead of setting edx_video_id to None, the code now retains its value, ensuring that videos already present in the Video Asset Library (VAL) continue to work as expected.

  • Video compatibility fix:
    • video.py: Updated parse_xml_new_runtime to retain the edx_video_id field, preventing issues where videos become unplayable or lose their ID in the editor after saving.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @AhtishamShahid!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 20, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

3 participants