Merge pull request #23 from openedx/bilalqamar95/node-v18-upgrade

feat: upgraded to node v18, added .nvmrc and updated workflows
openedx · May 15, 2023 · 343aa3d · 343aa3d
2 parents 8e9889f + c08a3a7
commit 343aa3d
Show file tree

Hide file tree

Showing 5 changed files with 632 additions and 2,306 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,17 +11,17 @@ on:
 jobs:
   tests:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node: [16]
     steps:
     - name: Checkout
       uses: actions/checkout@v2
 
+    - name: Setup Nodejs Env
+      run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
+
     - name: Setup Nodejs
       uses: actions/setup-node@v2
       with:
-        node-version: ${{ matrix.node }}
+        node-version: ${{ env.NODE_VER }}
 
     - name: Install dependencies
       run: npm ci

diff --git a/.github/workflows/lockfileversion-check.yml b/.github/workflows/lockfileversion-check.yml
@@ -10,4 +10,4 @@ on:
 
 jobs:
   version-check:
-    uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
+    uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,10 +12,12 @@ jobs:
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
+      - name: Setup Nodejs Env
+        run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
       - name: Setup Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: ${{ env.NODE_VER }}
       - name: Install dependencies
         run: npm ci
       # TODO: Uncomment the steps once the repo have appropriate unit tests and lint config in place

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+18