Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: updated React version #2224

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Apr 24, 2023

Description

  • find our previous ticket for React upgrade to 18
  • estimate how much time it would take to do the upgrade

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Apr 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 24, 2023

Thanks for the pull request, @PKulkoRaccoonGang!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 77d1dc3
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/646c704def15ba00088bce5d
😎 Deploy Preview https://deploy-preview-2224--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2d6c050) 91.38% compared to head (77d1dc3) 91.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2224   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         234      234           
  Lines        4120     4120           
  Branches      982      982           
=======================================
  Hits         3765     3765           
  Misses        348      348           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamstankiewicz adamstankiewicz linked an issue May 5, 2023 that may be closed by this pull request
9 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-react-version branch from a998cff to abfcb57 Compare May 5, 2023 10:53
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 5, 2023 10:54
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-react-version branch 4 times, most recently from 845d5e5 to 97b9955 Compare May 8, 2023 07:33
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 10, 2023 09:36
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [BD-46] DRAFT: updated React version [BD-46] feat: updated React version May 10, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-react-version branch 4 times, most recently from 0f3b113 to 95b58cd Compare May 19, 2023 07:12
@viktorrusakov viktorrusakov marked this pull request as draft May 23, 2023 06:21
@viktorrusakov
Copy link
Contributor

Converting to draft as we decided to postpone the upgrade until we have migrated from enzyme to react-testing-library, since enzyme has no official adapter for React 18 (and the one currently used in this PR is unreliable). See #2325 for further details.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-react-version branch from 95b58cd to 70e08ba Compare May 23, 2023 07:36
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/update-react-version branch from 70e08ba to 77d1dc3 Compare May 23, 2023 07:50
@openedx-webhooks
Copy link

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@viktorrusakov viktorrusakov removed a link to an issue May 24, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants