Skip to content

fix: removing enterprise specific code from platform#38117

Open
kiram15 wants to merge 8 commits intoopenedx:masterfrom
edx:kiram15/ENT-11475
Open

fix: removing enterprise specific code from platform#38117
kiram15 wants to merge 8 commits intoopenedx:masterfrom
edx:kiram15/ENT-11475

Conversation

@kiram15
Copy link
Contributor

@kiram15 kiram15 commented Mar 5, 2026

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@pwnage101
Copy link
Contributor

pwnage101 commented Mar 5, 2026

Wouldn't hurt to add this unit test (from the claude PR) to make sure the signal gets called, and maybe add in the docstring that external plugins may depend on it. This is a bit of an insurance policy against regressions.

https://github.com/openedx/openedx-platform/pull/38100/changes#diff-6daca8ceb97506291e5ae48e67b83b1406fdf689e8f73c83542d2a3eaa93fe4eR1521-R1534

Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE before updating this PR to bump edx-enterprise to include changes from openedx/edx-enterprise#2559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants