fix: Exclude UpstreamSyncMixin XBlock Fields from Advanced Settings#38069
Open
kdmccormick wants to merge 1 commit intomasterfrom
Open
fix: Exclude UpstreamSyncMixin XBlock Fields from Advanced Settings#38069kdmccormick wants to merge 1 commit intomasterfrom
kdmccormick wants to merge 1 commit intomasterfrom
Conversation
kdmccormick
force-pushed
the
kdmccormick/upstream-sync-advanced-settings
branch
3 times, most recently
from
d48ef2d to
60de6ad
Compare
We were previously explicitly excluding several of these fields, but had missed two recently-added ones: top_level_downstream_parent_key and TODO. This commit future-proofs us by excluding any XBlock Field defined on UpstreamSyncMixin.
kdmccormick
force-pushed
the
kdmccormick/upstream-sync-advanced-settings
branch
from
60de6ad to
2e72c66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously explicitly excluding several of these fields, but had missed two recently-added ones: top_level_downstream_parent_key and TODO.
This commit future-proofs us by excluding any XBlock Field defined on UpstreamSyncMixin.
details TBD