Skip to content

feat: make marketing email opt-in checkbox selectively ignorable#38042

Merged
iloveagent57 merged 1 commit intomasterfrom
aed/optional-marketing-checkbox
Mar 2, 2026
Merged

feat: make marketing email opt-in checkbox selectively ignorable#38042
iloveagent57 merged 1 commit intomasterfrom
aed/optional-marketing-checkbox

Conversation

@iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Feb 23, 2026

ported from #38022

We want to support a flow for SSO-enabled Enterprise customers who have agreed off-platform that none of their learners will opt-in to marketing emails or sharing research data. This change proposes to do so by adding an optional field that, when enabled, disables the presence of the two checkboxes on this registration form and sets their values to false.

Local Testing

See the added doc on how to test locally. Do one pass with the new model option disabled and private.py settings that have

ENABLE_THIRD_PARTY_AUTH = True
MARKETING_EMAILS_OPT_IN = True

Visit http://localhost:18000/auth/idp_redirect/saml-default, be redirected to mocksaml.com, then click "Sign In".
image

Now change your provider config to set "Skip registration optional checkboxes" to true.
Visit http://localhost:18000/auth/idp_redirect/saml-default again, be redirected to mocksaml.com, then click "Sign In".
image

@iloveagent57 iloveagent57 requested a review from a team as a code owner February 23, 2026 16:12
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Feb 23, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @iloveagent57!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 23, 2026
@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch 4 times, most recently from b36bac4 to d2bee6d Compare February 23, 2026 18:56
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any supporting information you can link to?

@iloveagent57
Copy link
Contributor Author

@kdmccormick Sorry for posting with empty description, I just updated it with what this code intends to support. good call on those exception handlers, we can clean that up.

@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch 3 times, most recently from b719d8e to e2044a6 Compare February 24, 2026 13:45
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Feb 24, 2026
@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch from e2044a6 to 316fcd5 Compare February 24, 2026 21:50
@iloveagent57 iloveagent57 changed the title feat: make marketing_emails_opt_in optional feat: make marketing email opt-in checkbox selectively ignorable Feb 24, 2026
@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch from 316fcd5 to db6b4f5 Compare February 25, 2026 19:04
@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch 5 times, most recently from 0049ae5 to fdd2ea0 Compare February 27, 2026 19:58
…ignorable

We want to support a flow for SSO-enabled Enterprise customers who have
agreed off-platform that none of their learners will opt-in to marketing emails
or sharing research data. This change proposes to do so by
adding an optional field that, when enabled, disables the presence of
the two checkboxes on this registration form and sets their values to false.

ENT-11401
@iloveagent57 iloveagent57 force-pushed the aed/optional-marketing-checkbox branch from fdd2ea0 to e8c9b20 Compare March 2, 2026 15:20
@iloveagent57 iloveagent57 merged commit 2fcce12 into master Mar 2, 2026
69 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Mar 2, 2026
@iloveagent57 iloveagent57 deleted the aed/optional-marketing-checkbox branch March 2, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants