feat: make marketing email opt-in checkbox selectively ignorable#38042
feat: make marketing email opt-in checkbox selectively ignorable#38042iloveagent57 merged 1 commit intomasterfrom
Conversation
|
Thanks for the pull request, @iloveagent57! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
b36bac4 to
d2bee6d
Compare
kdmccormick
left a comment
There was a problem hiding this comment.
Is there any supporting information you can link to?
|
@kdmccormick Sorry for posting with empty description, I just updated it with what this code intends to support. good call on those exception handlers, we can clean that up. |
b719d8e to
e2044a6
Compare
e2044a6 to
316fcd5
Compare
316fcd5 to
db6b4f5
Compare
0049ae5 to
fdd2ea0
Compare
…ignorable We want to support a flow for SSO-enabled Enterprise customers who have agreed off-platform that none of their learners will opt-in to marketing emails or sharing research data. This change proposes to do so by adding an optional field that, when enabled, disables the presence of the two checkboxes on this registration form and sets their values to false. ENT-11401
fdd2ea0 to
e8c9b20
Compare
ported from #38022
We want to support a flow for SSO-enabled Enterprise customers who have agreed off-platform that none of their learners will opt-in to marketing emails or sharing research data. This change proposes to do so by adding an optional field that, when enabled, disables the presence of the two checkboxes on this registration form and sets their values to false.
Local Testing
See the added doc on how to test locally. Do one pass with the new model option disabled and
private.pysettings that haveVisit

http://localhost:18000/auth/idp_redirect/saml-default, be redirected to mocksaml.com, then click "Sign In".Now change your provider config to set "Skip registration optional checkboxes" to true.

Visit
http://localhost:18000/auth/idp_redirect/saml-defaultagain, be redirected to mocksaml.com, then click "Sign In".