Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FC-0001: Account pages -> micro-frontend #326

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

UvgenGen
Copy link
Contributor

@UvgenGen UvgenGen commented May 2, 2022

Description:

Added ACCOUNT_PROFILE_URL and ACCOUNT_SETTINGS_URL settings.

edx-platform PR: openedx/edx-platform#30336
frontend-component-header PR: openedx/frontend-component-header#210

Supporting information

openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 2, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @UvgenGen! I've created OSPR-6652 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #326 (4952ecb) into master (9e1eb5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   80.85%   80.85%           
=======================================
  Files          38       38           
  Lines         888      888           
  Branches      164      164           
=======================================
  Hits          718      718           
  Misses        159      159           
  Partials       11       11           
Impacted Files Coverage Δ
src/config.js 36.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1eb5d...4952ecb. Read the comment docs.

@natabene
Copy link

natabene commented May 3, 2022

@dianakhuang I believe this is with your team, so please review and merge when you have a chance.

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 3, 2022
Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbrandes arbrandes linked an issue Oct 18, 2022 that may be closed by this pull request
@abdullahwaheed abdullahwaheed merged commit eca2003 into openedx:master Dec 8, 2022
@openedx-webhooks
Copy link

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DEPR]: Account pages -> micro-frontend
6 participants