-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0001: Account pages -> micro-frontend #326
Conversation
Thanks for the pull request, @UvgenGen! I've created OSPR-6652 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 38 38
Lines 888 888
Branches 164 164
=======================================
Hits 718 718
Misses 159 159
Partials 11 11
Continue to review full report at Codecov.
|
@dianakhuang I believe this is with your team, so please review and merge when you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
Added ACCOUNT_PROFILE_URL and ACCOUNT_SETTINGS_URL settings.
edx-platform PR: openedx/edx-platform#30336
frontend-component-header PR: openedx/frontend-component-header#210
Supporting information
openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: