chore: make sure links point to MFE not legacy #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that the legacy profile and account pages have been removed, we need to make sure that all of the links point to the MFE URLs; we were relying on the legacy applications to do redirection before. FIXES: APER-3884 FIXES: openedx/public-engineering#71
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #445 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 185 185
Lines 3859 3859
Branches 959 959
=======================================
Hits 3277 3277
Misses 564 564
Partials 18 18 ☔ View full report in Codecov by Sentry. |
MaxFrank13
approved these changes
Feb 11, 2025
Comment on lines
+17
to
+18
| 'ACCOUNT_PROFILE_URL', | ||
| 'ACCOUNT_SETTINGS_URL', |
There was a problem hiding this comment.
shouldn't these be added to .env.development to ensure support tools links work as expected locally?
There was a problem hiding this comment.
good catch, added, thank you.
now that the legacy profile and account pages have been removed, we need to make sure that all of the links point to the MFE URLs; we were relying on the legacy applications to do redirection before. FIXES: APER-3884 FIXES: openedx/public-engineering#71
|
if you approve, @DawoudSheraz, the new CC system means I can't merge this myself, I believe, so I'll wait for you. 😄 |
DawoudSheraz
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that the legacy profile and account pages have been removed, we need to make sure that all of the links point to the MFE URLs; we were relying on the legacy applications to do redirection before.
FIXES: APER-3884
FIXES: openedx/public-engineering#71