-
Notifications
You must be signed in to change notification settings - Fork 56
Replacing injectIntl with useIntl() part 2 #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing injectIntl with useIntl() part 2 #459
Conversation
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes React components by replacing the deprecated injectIntl
Higher-Order Component (HOC) with the useIntl()
hook from @edx/frontend-platform/i18n. This change improves unit test compatibility and follows current React best practices.
- Converted class components to functional components to use the
useIntl
hook - Removed
intl
prop dependencies and related PropTypes validation - Updated corresponding test files to remove mock
intl
prop requirements
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
CloseReviewConfirmModal.jsx | Updated functional component to use useIntl hook instead of injectIntl |
CloseReviewConfirmModal.test.jsx | Removed intl prop from test cases |
OverrideGradeConfirmModal.jsx | Updated functional component to use useIntl hook instead of injectIntl |
OverrideGradeConfirmModal.test.jsx | Removed intl prop from test cases |
SubmissionFiles.jsx | Converted class component to functional component with useIntl hook |
SubmissionFiles.test.jsx | Removed intl prop from test cases |
RadioCriterion.jsx | Converted class component to functional component with useIntl hook |
RadioCriterion.test.jsx | Removed intl prop from test cases |
CriterionFeedback.jsx | Converted class component to functional component with useIntl hook |
CriterionFeedback.test.jsx | Removed intl prop from test cases |
381a281
to
4fa6cae
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1082 1080 -2
Branches 159 159
=========================================
- Hits 1082 1080 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Once this is rebased I'll merge it!
Description
As part of Unit test improvement project, we replace all usages of the deprecated injectIntl HOC with the useIntl() hook from @edx/frontend-platform/i18n.
Closes #450
Files:
src/containers/CriterionContainer/RadioCriterion.jsx
src/containers/ReviewModal/components/CloseReviewConfirmModal.jsx
src/containers/CriterionContainer/CriterionFeedback.jsx
src/containers/ResponseDisplay/SubmissionFiles.jsx
src/containers/ReviewActions/components/OverrideGradeConfirmModal.jsx
CriterionFeedback
,RadioCriterion
andSubmissionFiles
class components were refactored into functional components in order to use the useIntl hook