-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: close sidebar on mobile after selecting a unit #1583
base: master
Are you sure you want to change the base?
feat: close sidebar on mobile after selecting a unit #1583
Conversation
Thanks for the pull request, @Agrendalath! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1583 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 331 331
Lines 5656 5659 +3
Branches 1357 1397 +40
=======================================
+ Hits 4785 4788 +3
Misses 854 854
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Makes sense to me! If you haven't already, can you just get a +1 from some product person, perhaps by asking on Slack #studio ? |
@bradenmacdonald, I posted a request on the |
Thank you for catching. This updated behavior makes sense to me. |
Description
When a user selects a unit on the course outline sidebar, it remains open. This behavior can be confusing on mobile devices because the sidebar is displayed on the entire screen. This PR changes the behavior to close the sidebar once the learner selects the unit.
Testing instructions
courseware.enable_navigation_sidebar
Waffle flag.Private-ref: BB-334 (temporary)