-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated Xpert component to be lazy loaded #1498
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
=======================================
Coverage 88.69% 88.69%
=======================================
Files 312 312
Lines 5501 5502 +1
Branches 1365 1365
=======================================
+ Hits 4879 4880 +1
+ Misses 605 604 -1
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. |
f8fde7a
to
842e2ac
Compare
842e2ac
to
a01e19d
Compare
@rijuma There doesn't seem to be any changes in bundle size, am I missing something? |
@rijuma Thanks for this PR! I believe the problem (with the bundle size not changing) is that If you can give |
It is. We have a ticket in our scope to move the learning assistant into its own plugin and remove all dependencies. The way it works right now unfortunately is by using the Redux store. I can put a hold on this PR until we move the assistant as a plugin (we have a ticket for that in our backlog). My thoughts for that ticket are to remove the redux store for its own store within a context or use another global state strategy. It will be picked up eventually. |
Related issues: #1482
To improve bundle size we are lazy loading Xpert from
frontend-lib-learning-assistant
.Bundlewatch before
Result breakdown at: https://ja2r7.app.goo.gl/5iYm4CybudWXSUSF6
Bundlewatch after
Result breakdown at: https://ja2r7.app.goo.gl/TXEwuYtUvirAdYFL8
There seem to be no evident improvement on the bundle size according to Bundlewatch.