Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate enterprise customer business logic to the BFF layer #1263

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Jan 29, 2025

Utilizes the BFF layer for metadata related to the enterprise customer metadata with the following serializer response update for the BFF layer within enterprise access (PR).

This PR also acts as a full cutover for the BFF layer in terms of removing any waffle or MFE config based flagging for the BFF API call. This PR refactors logic such that the determination for a BFF API call is solely dependent on the user's current route and deprecates all BFF related feature flags.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@brobro10000 brobro10000 force-pushed the hu/ent-9937 branch 2 times, most recently from 13376d0 to c1beb74 Compare January 31, 2025 17:16
@brobro10000 brobro10000 marked this pull request as ready for review February 11, 2025 22:12
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 81.39535% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.69%. Comparing base (64030b7) to head (633414d).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/components/app/routes/data/utils.js 70.37% 7 Missing and 1 partial ⚠️
src/components/academies/data/academyLoader.ts 50.00% 1 Missing ⚠️
src/components/course/data/courseLoader.ts 50.00% 1 Missing ⚠️
...ts/course/routes/externalCourseEnrollmentLoader.ts 50.00% 1 Missing ⚠️
src/components/dashboard/data/dashboardLoader.ts 50.00% 1 Missing ⚠️
src/components/microlearning/data/videosLoader.ts 50.00% 1 Missing ⚠️
...nts/program-progress/data/programProgressLoader.ts 66.66% 1 Missing ⚠️
src/components/program/data/programLoader.ts 50.00% 1 Missing ⚠️
src/components/search/data/searchLoader.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
+ Coverage   89.59%   89.69%   +0.10%     
==========================================
  Files         405      406       +1     
  Lines        8824     8833       +9     
  Branches     2064     2074      +10     
==========================================
+ Hits         7906     7923      +17     
+ Misses        883      877       -6     
+ Partials       35       33       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 force-pushed the hu/ent-9937 branch 3 times, most recently from 6071f5b to cfa68cb Compare February 13, 2025 18:48
@brobro10000 brobro10000 force-pushed the hu/ent-9937 branch 2 times, most recently from b61a1a1 to 345dbe4 Compare February 25, 2025 14:18
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , with some nits.

* // { shouldUpdateActiveEnterpriseCustomerUser: false, isBFFData: false, anotherFlag: "B" }
* // ]
*/
export const generateTestPermutations = (options) => Object.entries(options).reduce(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants