-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate enterprise customer business logic to the BFF layer #1263
base: master
Are you sure you want to change the base?
Conversation
13376d0
to
c1beb74
Compare
c1beb74
to
224d886
Compare
5a47226
to
d344054
Compare
d344054
to
d5d6f17
Compare
b97a32a
to
2c11fe8
Compare
2c11fe8
to
fcd9ecd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
+ Coverage 89.59% 89.69% +0.10%
==========================================
Files 405 406 +1
Lines 8824 8833 +9
Branches 2064 2074 +10
==========================================
+ Hits 7906 7923 +17
+ Misses 883 877 -6
+ Partials 35 33 -2 ☔ View full report in Codecov by Sentry. |
6071f5b
to
cfa68cb
Compare
cfa68cb
to
8dfe053
Compare
src/components/app/data/queries/extractEnterpriseCustomer.test.js
Outdated
Show resolved
Hide resolved
b61a1a1
to
345dbe4
Compare
345dbe4
to
e51d9f2
Compare
c025b5e
to
684f993
Compare
ed5b290
to
7345ec6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , with some nits.
* // { shouldUpdateActiveEnterpriseCustomerUser: false, isBFFData: false, anotherFlag: "B" } | ||
* // ] | ||
*/ | ||
export const generateTestPermutations = (options) => Object.entries(options).reduce( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, nice!
Utilizes the BFF layer for metadata related to the enterprise customer metadata with the following serializer response update for the BFF layer within enterprise access (PR).
This PR also acts as a full cutover for the BFF layer in terms of removing any waffle or MFE config based flagging for the BFF API call. This PR refactors logic such that the determination for a BFF API call is solely dependent on the user's current route and deprecates all BFF related feature flags.
For all changes
Only if submitting a visual change