Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a new plugin for the enterprise modal on dashboard #565

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Feb 12, 2025

Verizon requested that the modal that attempts to direct learners to the enterprise dashboard have to be either accepted or dismissed instead of being able to click out of it.

This is part of 3 different PRs that extract the enterprise modal into a plugin.

https://github.com/edx/edx-internal/pull/12301
https://github.com/edx/frontend-plugin-learner-dashboard/pull/58

Jira Ticket - ENT-9853

@kiram15 kiram15 requested a review from a team as a code owner February 12, 2025 07:07
@kiram15 kiram15 changed the title feat: adding a new plugin for the enterprise modal on dashbaord feat: adding a new plugin for the enterprise modal on dashboard Feb 12, 2025
@deborahgu deborahgu added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 12, 2025
@deborahgu
Copy link
Member

@kiram15, could we rename this plugin slot to be more generally applicable to the open source project? For example, it seems like this would be able to hold any initial modal, and isn't specific to enterprise. Is that right? It's just that we are using this slot for a modal that appears on first load to be the redirector for the Enterprise dashboard.

@kiram15 kiram15 changed the base branch from kiram15/ENT-9853 to master February 19, 2025 21:28
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (93bd883) to head (6f3fd02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   97.36%   97.44%   +0.08%     
==========================================
  Files         155      152       -3     
  Lines        1365     1330      -35     
  Branches      228      225       -3     
==========================================
- Hits         1329     1296      -33     
+ Misses         34       33       -1     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +26 to 27
<DashboardModalSlot />
{(hasCourses && showSelectSessionModal) && <SelectSessionModal />}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[consideration/thought question] Would it make sense to co-locate SelectSessionModal as the default modal within DashboardModalSlot? It could be a bit confusing to have default modals outside of DashboardModalSlot (e.g., when should a default dashboard modal be put in this modal-specific slot vs. outside the modal-specific slot?).

If intentional to keep default dashboard modals out of the DashboardModalSlot, perhaps DashboardModalSlot is renamed to DashboardCustomModalSlot to be explicit that its for custom modals, not default modals like SelectSessionModal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it'd make sense to have the SelectSessionModal as the default content as well, and it received some agreement during the most recent Frontend Working Group meeting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we have a customer waiting upon this change, I think this would be a good idea to accomplish as a fast-follow

@kiram15 kiram15 force-pushed the kiram15/ENT-9853 branch 3 times, most recently from bc580d9 to 4a8814f Compare February 25, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants