feat: show migration status in libraries list [FC-0097] #2417
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
open-source-contribution
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
- Coverage 94.63% 94.62% -0.02%
==========================================
Files 1180 1181 +1
Lines 26151 26174 +23
Branches 5836 5827 -9
==========================================
+ Hits 24747 24766 +19
- Misses 1333 1337 +4
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
navinkarkera
force-pushed
the
navin/fal-4236/library-migration-status
branch
from
382cef9 to
b608746
Compare
Also convert files to typescript
navinkarkera
force-pushed
the
navin/fal-4236/library-migration-status
branch
from
b608746 to
5de56af
Compare
navinkarkera
changed the title
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @navinkarkera!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
|
||
| // Libraries v2 tab should not be shown | ||
| expect(screen.queryByRole('tab', { name: librariesBetaTabTitle })).toBeNull(); | ||
|
|
||
| const librariesTab = await screen.findByRole('tab', { name: tabMessages.librariesTabTitle.defaultMessage }); | ||
| fireEvent.click(librariesTab); | ||
| await user.click(librariesTab); |
There was a problem hiding this comment.
Out of curiosity, did the userEvent work here better than the fireEvent? Would you happen to know why?
There was a problem hiding this comment.
Don't think it works better here, the tests were failing and I changed this but the real reason was incorrect timing of mocking requests. Since it is recommended to use userEvent, I did not revert this change.
There was a problem hiding this comment.
I didn't know that it was the recommended way! Thanks!
navinkarkera
force-pushed
the
navin/fal-4236/library-migration-status
branch
from
72c4d24 to
5de56af
Compare
Description
Adds migration status to library cards in legacy libraries tab in studio home.
Also converts javascript files to typescript and replaces redux with react query for related api calls.
Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4236Testing instructions
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'