Skip to content

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Jul 18, 2025

Description

Supporting information

Testing instructions

Testing on the sandbox

Deadline

None

Other information

This is a label trigger to add an Issue o PR to the frontend Core Contributor project board
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 18, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald could you review this?

@ChrisChV ChrisChV requested a review from bradenmacdonald July 18, 2025 19:58
@ChrisChV ChrisChV self-assigned this Jul 18, 2025
@bradenmacdonald
Copy link
Contributor

@ChrisChV Sure, but could you please explain more about how this works and how to test it? What is the trigger - when a PR is assigned to a CC, or when an issue is assigned to a CC, or when a CC opens a PR? Can you include a link to the "the frontend Core Contributor project board" ? How does the status get updated once it's on the board - manually or automatically? Can it apply retroactively?

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 28, 2025
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Jul 28, 2025
@ChrisChV
Copy link
Contributor Author

Sure, but could you please explain more about how this works and how to test it? What is the trigger - when a PR is assigned to a CC, or when an issue is assigned to a CC, or when a CC opens a PR? Can you include a link to the "the frontend Core Contributor project board" ?

@bradenmacdonald Thanks, I updated the description with more details of this action.

How does the status get updated once it's on the board - manually or automatically?

For now, manually, but we are thinking of automating it as well, if the initial MVP works.

Can it apply retroactively?

Yes, but adding the label manually


About testing this, I haven't found a way to test it in the openedx organization, but in the description, I've added a way to test it in a sandbox, if that doesn't work, I could try implementing it in the open-craft organization.

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, approved! Let's merge and try it on here, and if it's working then I'll approve openedx/edx-platform#37044 as well (remind me)

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.64%. Comparing base (720b591) to head (2b649b4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2302   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1187     1187           
  Lines       26220    26220           
  Branches     5679     5679           
=======================================
  Hits        24817    24817           
  Misses       1344     1344           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV merged commit ab645ad into openedx:master Sep 10, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Sep 10, 2025
@ChrisChV ChrisChV deleted the chris/cc-board-config branch September 10, 2025 22:25
@ChrisChV
Copy link
Contributor Author

@bradenmacdonald I tested the action, it raised this issue. I fixed it in #2441

@ChrisChV
Copy link
Contributor Author

Status update: We got this issue related to the PROJECTS_TOKEN. It is being resolved in openedx/axim-engineering#1523 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants