fix: load sequences in unit page #1867

ihor-romaniuk · 2025-04-28T12:34:07Z

Description

Handle loading errors when opening the course unit page via direct link as an unauthorized user.

Backport:

teak branch fix: load sequences in unit page #1876

Screenshots

Case 1: Open course unit page

Case 2: Open Split Test xblock content

Unexpected Application Error!
Cannot read properties of undefined (reading 'upstreamLink')
TypeError: Cannot read properties of undefined (reading 'upstreamLink')
    at T2 (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/app.a1ce6d6e6800b33ff46c.js:1:5941058)
    at pa (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1924360)
    at ks (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1938398)
    at wu (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1984168)
    at gl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972553)
    at hl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972481)
    at pl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972344)
    at nl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1969179)
    at tl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1967735)
    at _ (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1005861)

Testing instructions

Open the course unit page directly while not signed in.
Sign in to the system.
Case 1
-- Verify that the course unit page loads correctly after authentication.
Case 2
-- Add Split Test xBlock
-- Open Split Test xBlock content page
-- Verify that the Split Test xBlock content page loads correctly.

Other information

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_NEW_MFES:
  authoring:
    port: 18000
    repository: https://github.com/raccoongang/frontend-app-course-authoring.git
    version: romaniuk/fix/load-sequences

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: |
  MFE_CONFIG["ENABLE_UNIT_PAGE"] = True
  MFE_CONFIG["ENABLE_NEW_EDITOR_PAGES"] = True

openedx-webhooks · 2025-04-28T12:34:13Z

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks · 2025-04-28T12:34:13Z

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2025-04-28T12:45:42Z

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (01243af) to head (89206fa).
Report is 29 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/data/thunk.js	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
+ Coverage   93.98%   94.01%   +0.03%     
==========================================
  Files        1155     1162       +7     
  Lines       24146    24434     +288     
  Branches     5116     5188      +72     
==========================================
+ Hits        22693    22971     +278     
- Misses       1385     1395      +10     
  Partials       68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bradenmacdonald · 2025-04-29T20:45:32Z

Open the course unit page directly while not signed in.

I think you are missing the root cause here.

When I open a unit page directly and then log in, without accessing other Authoring MFE pages first, I see this in the network logs:

The second request fails because the studio_session_id cookie is not set, and the /xblock/container/:id endpoint is not a "proper" REST API endpoint - it doesn't use DRF and doesn't accept auth headers, only cookies.

So really, I think we need to fix this properly - either:

Remove all calls to the old /xblock/container/ endpoint and use /api/contentstore/v1/container_handler/ everywhere instead - this will also speed up loading because we don't call two similar APIs but just one. Or:
Fix the old /xblock/container/ endpoint so that it accepts header authentication. But I'd strongly prefer option 1 because the old /xblock/container/ endpoint is also very confusing - if you open it in your browser without sending the right JSON headers, it shows a 404 error even though it's a valid URL.

It seems like there's also duplicate requests being made to each of these endpoints, so in the long term we really should be using React Query to load the data since it will de-duplicate the requests better.

However, if you don't have time to fix this "properly" now, I'm fine with merging the fix you've made here - it is reasonable. But my big concern is that we're just going to get more errors like this until we fix the root cause, especially in code that's not using TypeScript so nobody has any idea if fields like upstreamInfo are always defined or not.

bradenmacdonald · 2025-04-29T20:51:39Z

src/course-unit/course-sequence/hooks.js

  const sequenceIds = useSelector(getSequenceIds);
  const sequenceIndex = sequenceIds.indexOf(currentSequenceId);
-  const unitIndex = sequence.unitIds.indexOf(currentUnitId);
+  const unitIndex = sequence.unitIds?.indexOf(currentUnitId);


Adding ? means that unitIndex can be undefined, and in that case we shouldn't be adding to it below on line 21. If you convert this to TypeScript it would show this as an error:

bradenmacdonald · 2025-04-29T20:55:16Z

@navinkarkera @rpenido @pomegranited FYI on this PR/error.

arbrandes · 2025-05-01T19:17:16Z

What @bradenmacdonald said:

we're just going to get more errors like this until we fix the root cause

What I suggest is for a new issue to be created with the relevant info, and for us to merge this one as a workaround for Teak in the meantime.

ihor-romaniuk · 2025-05-07T12:04:38Z

@arbrandes @bradenmacdonald Thanks for your feedback.

I have replaced the old /xblock/container/ endpoint with the new /api/contentstore/v1/container_handler/.
It helps us to remove duplicate requests and avoid errors which I fixed initially.

open-craft-grove · 2025-05-07T13:55:32Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes · 2025-05-07T19:19:06Z

@ihor-romaniuk, I still see the error (or an error) when I go to the unit page directly while logged out, then immediately log in:

This is in this PR's sandbox, btw.

pomegranited · 2025-05-20T01:49:09Z

This is looking ready for CC review now -- @navinkarkera or @ChrisChV can you review? I'm not CC on this repo :)

pomegranited · 2025-05-21T00:41:25Z

Hi @ihor-romaniuk , could you add a bit of test coverage to fix the code coverage?

bradenmacdonald · 2025-05-21T17:11:05Z

@arbrandes Would you be able to take another look at this soon? I think it's a pretty high priority bugfix. Or do you need someone else to take on the review?

And yes, @ihor-romaniuk , we'll need the codecov check passing to be able to merge this.

open-craft-grove · 2025-05-27T23:24:08Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

ihor-romaniuk · 2025-05-28T06:30:24Z

@pomegranited @bradenmacdonald @arbrandes Test coverage was updated and it's ready for review.

open-craft-grove · 2025-05-28T07:29:21Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald

Nice! It's looking good and it fixes the bugs that I have seen. Since it's such a big refactor I'm not sure if we should backport it to Teak though. Perhaps just the

part, or some smaller bit like that is what we backport?

Edit: that's done - #2042

src/course-unit/data/api.js

bradenmacdonald · 2025-05-30T20:45:16Z

@arbrandes would you be able to take a quick look here too before we merge, or no?

open-craft-grove · 2025-06-04T19:04:11Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

PKulkoRaccoonGang

I quickly looked through it, except for 1 minor comment LGTM! 💯

src/course-unit/CourseUnit.test.jsx

open-craft-grove · 2025-06-05T08:57:57Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes

Looks good to me! Let's get it in!

…2246) This is a simple version of the fix for Teak; on master it was fixed with #1867

This handles loading errors when opening the course unit page via direct link as an unauthorized user.

This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <[email protected]>

* refactor: remove custom order function from course libraries list (openedx#1865) (openedx#1888) (cherry picked from commit bc18fff) * perf: use Library search results to populate container card preview [FC-0083] [TEAK] (openedx#1889) * fix: several library unit page UX bugs (openedx#1868) * fix: rename "Organize" tab to "Manage" * fix: duplicate key warnings * fix: uniform messages while adding to collection * fix: do not allow units be added to a unit (cherry picked from commit 0fdc460) * perf: use Library search results to populate container card preview (openedx#1820) * fix: use Library search results to populate container card preview * feat: show published children when showing only published Unit content * fix: nits (cherry picked from commit 24e4695) --------- Co-authored-by: Rômulo Penido <[email protected]> * fix: manage access modal on duplicated xblock (openedx#1874) * fix: unit pages ux bugs [FC-0083] (openedx#1884) (openedx#1916) This PR fixes some UX bugs related to the unit pages: * Sort for "recently modified" on unit tab does not update after adding new components to units * Change component delete warning message It's a backport of openedx#1884 * fix: UX issues in unit page (openedx#1913) (openedx#1923) Fixes the following issues: * Selection behavior * Component selection is by header click only * Newly created blocks within a unit should be selected on creation/save, appear selected, and have their sidebar open * Some long text components seem to display at the default height rather than a longer height * Within the full-page unit view, the "add to collection" overflow menu item on components does not seem to work/only opens the sidebar. * Draft status indicator text is not vertically centered with icon * When reordering, dragging a short component past a long component often causes a strange stutter effect. * When dragging to reorder a component, moving quickly or scrolling often causes the drag handle to be lost / causes the block to jump somewhere else * Reordering may not consistently support a keyboard-accessible option to change order, like in course authoring * Tag button on component header opens the old tag side pane (cherry picked from commit 8c3fab3) * fix: invalidate search results when publishing all changes in library (openedx#1925) (openedx#1927) (cherry picked from commit cdb8016) Co-authored-by: Braden MacDonald <[email protected]> * fix: improve focus/selected style on library authoring (openedx#1918) (openedx#1930) Improves the focus and selected styles from the LibraryPage and UnitPage. * fix: review/sync bugs [FC-0083] (openedx#1905) (openedx#1941) Fixes issues related to component libraries' review/sync flow * Inconsistent sync pane title versions * Library content shown in preview warning only appears in review changes modal when that modal is opened from the review tab * Some new changes only appear within library review tab on scroll at top of list * Vertically misaligned sync icon in review changes message on course outline * Show available updates whenever content is updated, regardless of number of updates available * fix: Issue with read-only units in libraries & published version of units in library units picker (openedx#1940) Fixes the issues from openedx#1633 (comment) * In successfully added units, the "add new component" widget appears sometimes * In the "add existing unit" modal, the preview shows draft versions of units * fix: search modal refresh on typing (openedx#1938) (openedx#1948) * [Teak] backport openedx#1949, openedx#1999 and openedx#2002 (openedx#2006) * feat: select component and show sidebar on edit (openedx#1949) Select component that is being edited in library and show its sidebar. Also fixes issue with children component listing in library unit page (cherry picked from commit 08ac1c0) * fix: search text flickering (openedx#1999) Fix flickering issue in search field. (cherry picked from commit 6f3b7ab) * feat: open collection or unit page on double click only (openedx#2002) Opens collection or unit page only on double click. (cherry picked from commit 503642b) * fix: change InplaceTextEditor style and add optimistic update (openedx#1953) (openedx#2014) * Optimistic update for renaming Components, Collections and Containers * Change the InplaceTextEditor to show the new text until the onSave promise resolves * Change the InplaceTextEditor style to: Always show the rename button * fix: rename library publish button (openedx#2015) * fix: do open editor of new xblock when duplicating (openedx#2017) * feat: display editors as modals (openedx#1838) * fix: do open editor of new xblock when duplicating (openedx#1887) Fixes bug where after duplicating an xblock, the editor modal of the old xblock is being open instead of the new copied xblock. * [Teak] fix: Inconsistent publish status filter menu placement & fix: Remove never published filter from component picker (openedx#2021) * fix: Inconsistent publish status filter menu placement (openedx#1966) * fix: Remove never published filter from component picker (openedx#1947) Removes the never-published filter option from the component picker and unit picker. * fix: refresh xblock inline after accepting/rejecting library sync (openedx#2022) (openedx#2028) Instead of reloading the entire Unit after syncing changes from the library, just reload the xblock that was changed. (cherry picked from commit ac5574d) * fix: set maxHeight on TextEditor TinyMce widget [FC-0090] (openedx#2024) (openedx#2030) Sets a max_height=500px for the TinyMCE editor when editing a Text/Html component. This prevents the autoresize plugin from expanding the editor textarea beyond the bounds of the editor modal. ⚠️ Because the max height can only be a numeric pixel value, we can't use clever settings like vh or %, and so we're forced to limit the height of the editor to a fixed size for all screen sizes in order to address this issue. (cherry picked from commit c5f7d0c) * fix: upstreamInfo is not always provided (openedx#2041) (openedx#2042) (cherry picked from commit 3fc0f27) * fix: selection card wiggle (openedx#2047) * fix: set unit preview readonly on sidebar (openedx#2008) (openedx#2059) Make the unit preview on the sidebar read-only and add `Truncate` to the `InplaceTextEditor` * fix: backport changes for html button in text component markdown editor (openedx#2065) * fix: markdown editor issues in modal (openedx#2076) This PR resolves rendering issues with the Markdown editor inside the modal. The problem began after a PR [1] introduced the use of modals for the editor. The EditorPage [2] component expects a `isMarkdownEditorEnabledForCourse` prop, which was missing in that implementation. [1] openedx#1838 [2] https://github.com/openedx/frontend-app-authoring/pull/1838/files#diff-147218ef88726880178ea895988a5d3feaf2c0c4459086a8de7a4080cbe37de7R226 Backports openedx#2074 * fix: Expand all now expands subsections (openedx#2085) * fix: files & uploads menu was truncated due to overflow-x (openedx#2071) (openedx#2077) * fix: (backport) remove an extra editing xblock modal on unit page (openedx#2111) (openedx#2130) * fix: (backport) enable markdown editor in libraries (openedx#2098) * fix: enable markdown editor for problems in libraries too This fix is also achieved on master via 5991fd3 / openedx#2068 but this is a simpler fix, not a direct backport of that refactor. * fix: remove duplicate markdown_edited save request (openedx#2127) Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Backports: 62589ae --------- Co-authored-by: Muhammad Anas <[email protected]> * fix: remove icon and empty breadcrumb from libraries (openedx#2129) (openedx#2133) * fix: (backport) text truncate issue in the search modal (openedx#2151) * [Teak] fix: published name in unit sidebar in container picker & Issues on Inplace Editor (openedx#2140) Backport of fix: show unit published name in sidebar on content picker [FC-0090] openedx#2100 Backport of fix: Issue on the Inplace editor [FC-0090] openedx#2101 * feat: add `v2` `CourseAuthoringUnitSidebarSlot` (openedx#2000) * fix: advanced-settings api should not camel-case return value (backport) (openedx#2087) * fix: advanced-settings api should not camel-case return value (openedx#1581) * fix: update advanced module list not working (openedx#2189) Backend was still expecting `{'advanced_modules', {'value': ['poll', 'problem-builder', 'h5pxblock']}}` but without this change, it was receiving `{'advancedModules', ['poll', 'problem-builder', 'h5pxblock']}` Follow up to openedx#1581 --------- Co-authored-by: Muhammad Faraz Maqsood <[email protected]> * fix: clear selection on files & uploads page after deleting (backport) (openedx#2228) * refactor: remove selected rows when deleting or adding elements * refactor: ensure unique asset IDs when adding new ones * refactor: remove unnecessary loading checks in mockStore function * test: add unit tests for TableActions component * fix: loading unit page directly from link after logging in in Teak (openedx#2246) This is a simple version of the fix for Teak; on master it was fixed with openedx#1867 * fix: pages and resources plugins not rendered (openedx#1885) * docs: (backport) adding comprehensive readme documentation for plugin slots (openedx#2340) * fix: publish btn doesn't show after component edit When we edit & save the component, publish button doesn't show up until we refresh the page manualy or open this unit by opening previous unit and coming back to this unit again. In this commit, we are dispatching a storage event whenever we edit the component, it'll refresh the page & show the publish button as expected. --------- Co-authored-by: Navin Karkera <[email protected]> Co-authored-by: Jillian <[email protected]> Co-authored-by: Rômulo Penido <[email protected]> Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Braden MacDonald <[email protected]> Co-authored-by: Chris Chávez <[email protected]> Co-authored-by: Daniel Valenzuela <[email protected]> Co-authored-by: Tony Busa <[email protected]> Co-authored-by: Muhammad Anas <[email protected]> Co-authored-by: Victor Navarro <[email protected]> Co-authored-by: diana-villalvazo-wgu <[email protected]> Co-authored-by: bydawen <[email protected]> Co-authored-by: Arunmozhi <[email protected]> Co-authored-by: José Ignacio Palma <[email protected]> Co-authored-by: Muhammad Faraz Maqsood <[email protected]> Co-authored-by: Brayan Cerón <[email protected]> Co-authored-by: Jansen Kantor <[email protected]> Co-authored-by: Jacobo Dominguez <[email protected]> Co-authored-by: Muhammad Faraz Maqsood <[email protected]>

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 28, 2025

openedx-webhooks added this to Contributions Apr 28, 2025

github-project-automation bot moved this to Needs Triage in Contributions Apr 28, 2025

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 28, 2025

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from d83432e to a6892c0 Compare April 29, 2025 14:57

ihor-romaniuk mentioned this pull request Apr 29, 2025

fix: load sequences in unit page #1876

Closed

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from a6892c0 to ad1b589 Compare April 29, 2025 15:25

ihor-romaniuk marked this pull request as ready for review April 29, 2025 15:27

ihor-romaniuk requested review from PKulkoRaccoonGang, arbrandes and bradenmacdonald April 29, 2025 15:28

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from ad1b589 to a079913 Compare April 29, 2025 15:36

bradenmacdonald reviewed Apr 29, 2025

View reviewed changes

PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 30, 2025

PKulkoRaccoonGang assigned ihor-romaniuk and PKulkoRaccoonGang Apr 30, 2025

mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 1, 2025

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from 3629deb to ea6e13b Compare May 7, 2025 12:01

ihor-romaniuk added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels May 7, 2025

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from 7a3b305 to ce05909 Compare May 7, 2025 20:01

bradenmacdonald mentioned this pull request May 20, 2025

Clicking "View" on a Problem Bank shows an upstreamLink error. #2007

Closed

bradenmacdonald mentioned this pull request May 23, 2025

Double Edit Buttons on Unit Course Authoring Page #1986

Closed

ihor-romaniuk added 2 commits May 27, 2025 21:14

fix: load sequences in unit page

76538f6

fix: replace API endpoint for getting unit data on course unit page

c5cda97

ihor-romaniuk force-pushed the romaniuk/fix/load-sequences branch from 73cc156 to c5cda97 Compare May 27, 2025 20:44

fix: update tests

0a58ddf

bradenmacdonald approved these changes May 28, 2025

View reviewed changes

src/course-unit/data/api.js Show resolved Hide resolved

refactor: change getCourseSectionVerticalData to getVerticalData

51eeb0d

PKulkoRaccoonGang approved these changes Jun 4, 2025

View reviewed changes

src/course-unit/CourseUnit.test.jsx Outdated Show resolved Hide resolved

fix: remove commented line

89206fa

arbrandes approved these changes Jun 5, 2025

View reviewed changes

arbrandes merged commit 9a2dac6 into openedx:master Jun 5, 2025
7 checks passed

github-project-automation bot moved this from In Eng Review to Done in Contributions Jun 5, 2025

ihor-romaniuk deleted the romaniuk/fix/load-sequences branch June 5, 2025 14:29

Anas12091101 mentioned this pull request Jul 1, 2025

fix: loading unit page directly from link after logging in in Teak #2246

Merged

bradenmacdonald pushed a commit that referenced this pull request Jul 9, 2025

fix: loading unit page directly from link after logging in in Teak (#…

2973614

…2246) This is a simple version of the fix for Teak; on master it was fixed with #1867

asadali145 mentioned this pull request Sep 2, 2025

fix: enable publish button after component edit #2418

Closed

asadali145 pushed a commit to mitodl/frontend-app-course-authoring that referenced this pull request Sep 4, 2025

fix: load sequences in unit page (openedx#1867)

a81793b

This handles loading errors when opening the course unit page via direct link as an unauthorized user.

asadali145 mentioned this pull request Sep 4, 2025

[backport] fix: load sequences in unit page #2424

Merged

bradenmacdonald pushed a commit that referenced this pull request Sep 9, 2025

fix: load sequences in unit page (#1867) (#2424)

f459f53

This handles loading errors when opening the course unit page via direct link as an unauthorized user. Co-authored-by: Ihor Romaniuk <[email protected]>

fix: load sequences in unit page #1867

fix: load sequences in unit page #1867

Conversation

ihor-romaniuk commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Backport:

Screenshots

Testing instructions

Other information

Uh oh!

openedx-webhooks commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Apr 28, 2025

Uh oh!

codecov bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bradenmacdonald commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bradenmacdonald Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald commented Apr 29, 2025

Uh oh!

arbrandes commented May 1, 2025

Uh oh!

ihor-romaniuk commented May 7, 2025

Uh oh!

open-craft-grove commented May 7, 2025

Uh oh!

arbrandes commented May 7, 2025

Uh oh!

pomegranited commented May 20, 2025

Uh oh!

pomegranited commented May 21, 2025

Uh oh!

bradenmacdonald commented May 21, 2025

Uh oh!

open-craft-grove commented May 27, 2025

Uh oh!

ihor-romaniuk commented May 28, 2025

Uh oh!

open-craft-grove commented May 28, 2025

Uh oh!

bradenmacdonald left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bradenmacdonald commented May 30, 2025

Uh oh!

open-craft-grove commented Jun 4, 2025

Uh oh!

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

open-craft-grove commented Jun 5, 2025

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ihor-romaniuk commented Apr 28, 2025 •

edited

Loading

openedx-webhooks commented Apr 28, 2025 •

edited

Loading

codecov bot commented Apr 28, 2025 •

edited

Loading

bradenmacdonald commented Apr 29, 2025 •

edited

Loading

bradenmacdonald left a comment •

edited

Loading