-
Notifications
You must be signed in to change notification settings - Fork 123
fix: use Library search results to populate container card preview [FC-0083] #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Library search results to populate container card preview [FC-0083] #1820
Conversation
Thanks for the pull request, @pomegranited! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1820 +/- ##
==========================================
+ Coverage 93.78% 93.79% +0.01%
==========================================
Files 1147 1147
Lines 23894 23896 +2
Branches 5145 5043 -102
==========================================
+ Hits 22409 22414 +5
- Misses 1408 1414 +6
+ Partials 77 68 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f91c9ef
to
90c6f9b
Compare
90c6f9b
to
abc3b5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @pomegranited!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
I left only some nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited Looks good, thank you! 👍
- I tested this: (Verified card preview counts)
- I read through the code
- I checked for accessibility issues
- Includes documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and is working nicely, but there's a conflict. Can you please fix it and then I'll merge?
…penedx#1820) * fix: use Library search results to populate container card preview * feat: show published children when showing only published Unit content * fix: nits (cherry picked from commit 24e4695)
…penedx#1820) * fix: use Library search results to populate container card preview * feat: show published children when showing only published Unit content * fix: nits (cherry picked from commit 24e4695)
…FC-0083] [TEAK] (#1889) * fix: several library unit page UX bugs (#1868) * fix: rename "Organize" tab to "Manage" * fix: duplicate key warnings * fix: uniform messages while adding to collection * fix: do not allow units be added to a unit (cherry picked from commit 0fdc460) * perf: use Library search results to populate container card preview (#1820) * fix: use Library search results to populate container card preview * feat: show published children when showing only published Unit content * fix: nits (cherry picked from commit 24e4695) --------- Co-authored-by: Rômulo Penido <[email protected]>
Description
Use the
content.childUsageKey
list from the content search metadata when displaying a Unit card, orcontent.published.childUsageKey
when displaying only a Unit's published content.This change fixes a performance bug for Library Authors, but does not otherwise alter their user experience.
Supporting information
Part of: #1778
Blocked by: openedx/edx-platform#36528
Private-ref: FAL-4139
Testing instructions
Unit card preview should show no blocks.
Unit card preview should update automatically and to show an icon for each component type added (up to 5).
Once >5 components have been added, the Unit card preview should show the first 4 component type icons, then +N for each subsequent component.
The Unit preview should only show icons from the published Unit children, not the draft.