-
Notifications
You must be signed in to change notification settings - Fork 122
fix: include plugins in i18n extraction script #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include plugins in i18n extraction script #1802
Conversation
Thanks for the pull request, @igobranco! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1e5c279
to
df49ac8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1802 +/- ##
========================================
Coverage 93.89% 93.89%
========================================
Files 1153 1153
Lines 24054 24054
Branches 5200 5096 -104
========================================
Hits 22585 22585
- Misses 1392 1401 +9
+ Partials 77 68 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@OmarIthawi can you review this? |
Add the additional source `plugins` folder on the `fedx-scripts` extract translations. This can be configured because the frontend-build v14.5.0 now supports additional source folders using the `--include` extra argument.
df49ac8
to
817f651
Compare
Rebase on master to fix a git conflict. |
@bradenmacdonald Can you review this PR, so we can improve localization? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @igobranco.
Looks good from my side. @brian-smith-tcril @bradenmacdonald would you mind merging this if all is okay? I don't have permissions to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR extract more translations to be translated from the exiting source code, when translated those new strings, it will improve localization.
frontend-build
to thev14.5.0
, with the support for additional source folders.plugins
folder to be used as source folder for i18n extraction.Executing this command before and after this PR, and the prerequisites. You will see an increase of the extracted strings to be translated.
From 1730 before to 2471 after.
Depends on / prerequisites
Any.
Testing instructions
Run
Manually translate some new extracted strings to be translated, for example for
pt_PT
locale add the next json lines to the filesrc/i18n/messages/frontend-app-course-authoring/pt_PT.json
:So when editing a "problem", URL: http://apps.local.openedx.io:2001/authoring/course/course-v1:OpenedX+DemoX+DemoCourse/editor/problem/block-v1:OpenedX+DemoX+DemoCourse+type@problem+block@59c24f8a4d5c46af8bfb5fc9cd4bb611
The modal title and action buttons will be translated/localized, view screenshot:

Related to: