[sumac] fix: allow user provided value if can auto-create orgs [FC-0076] #1678
Conversation
…nedx#1582) Allows Content Authors to auto-create an organization when creating a library, if auto-creating orgs is allowed by the platform.
|
Thanks for the pull request, @pomegranited! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
pomegranited
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/sumac.master #1678 +/- ##
============================================================
Coverage ? 93.23%
============================================================
Files ? 1050
Lines ? 20427
Branches ? 4297
============================================================
Hits ? 19045
Misses ? 1325
Partials ? 57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @pomegranited!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
…n creating a course [FC-0076] (openedx#1689) The fixes for openedx#1577 caused issues with edx.org's Global Staff users not being able to create courses. edx.org/2U Global Staff are seeing an empty Organization drop-down list. This issue arose due to misuse of two similarly-named flags returned by the contentstore's home API * `can_create_organizations`: granted to Global Staff or everyone if `FEATURES[ENABLE_CREATOR_GROUP] == True`, * `allow_to_create_new_org`: which is actually about auto-creating organizations, so both `can_create_organizations` + `settings.ORGANIZATIONS_AUTOCREATE` must be True In this change, we use `canCreateOrganizations` to decide whether the user can see the full list of organizations when creating courses. We preserve the use of `allowToCreateNewOrg` when deciding whether to allow users to "typeahead" to create a new organization not in the drop-down list. (cherry picked from commit e5360dc)
Description
Backports #1582 + #1689 to Sumac.
Supporting information
Testing instructions