[sumac] fix: bugs with ExpandableTextArea toolbars & modals in problem editor [FC-0076]

[pomegranited]

Description

Backports the bugfixes from #1646 to Sumac.

Supporting information

• Backports fixes for Clicking options in the formatting toolbar attempts to close the editor #1637 +
  Formatting Toolbar Blocking Text Input #1636
• Private-ref: FAL-4085

Testing instructions

• Run this branch in your sumac tutor devstack.
• Follow instructions on Fix problem input [FC-0076] #1646 to test these changes.
  See notes below.

Other information

1. Sumac doesn't support adding images to content library blocks, and so the tinymce image button will not show in any of the editors.
   Partial support for library block assets is in Sumac, but adding full support requires backporting these feature PRs: feat: upload images from the TinyMCE in library editor #1458, test: fix contentContainer test #1516, fix: map image upload feature with enableImageUpload prop in TinyMceWidget #1527 (and more)
2. The library header bug fixed here was not needed for Sumac, so this change was omitted from this PR.

[openedx-webhooks]

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (open-release/sumac.master@e0ec87c). Learn more about missing BASE report.

Additional details and impacted files

@@                     Coverage Diff                      @@
##             open-release/sumac.master    #1673   +/-   ##
============================================================
  Coverage                             ?   93.23%           
============================================================
  Files                                ?     1050           
  Lines                                ?    20420           
  Branches                             ?     4374           
============================================================
  Hits                                 ?    19038           
  Misses                               ?     1322           
  Partials                             ?       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rpenido]

LGTM 👍
Thank you for your work, @pomegranited!

• I tested this using the instructions from the PR
• I read through the code
• I checked for accessibility issues
• Includes documentation

2. The library header bug fixed here was not needed for Sumac, so this change was omitted from this PR.

Clicking on the library name in the header redirects me to http://apps.local.openedx.io:2001/authoring/authoring/library/lib:orgA:lib1, so it still throws an error.

Do you think we can fix it (here or in another PR)?

[pomegranited]

Hi @rpenido , I'm not seeing the issue you're seeing with the library header when I run this code in sumac? Are you positive you're testing with this branch?

[rpenido]

Hi @rpenido , I'm not seeing the issue you're seeing with the library header when I run this code in sumac? Are you positive you're testing with this branch?

@pomegranited Doublechecked and (for this PR 😅) I am using the right branch!
The code is a bit different from master, but the error comes from here:

https://github.com/open-craft/frontend-app-authoring/blob/9dec79834344346e81d1952b7a130aca5d48b1d9/src/header/Header.tsx#L62-L64

  const outlineLink = !isLibrary
    ? `${studioBaseUrl}/course/${contextId}`
    : `/library/${contextId}`;

[pomegranited]

@ChrisChV did you see the same problem with the header as @rpenido did? I'm still not seeing the same problem on my sumac dev stack, but am rebuilding the mfe image just in case.

edit my rebuild still shows this as not an issue -- really don't know what we're doing differently here!