Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render proper visibility message on self-paced course type #1665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bra-i-am
Copy link
Contributor

Description

This PR fixes the message displayed in the Subsection visibility section of the Configure modal within the studio Course Outline when a course is either isSelfPaced or not.

Supporting information

Testing instructions

  • Mount this MFE using this PR's branch
  • Access to a course in the Studio
  • Go to Schedule & details, change the date to a future date, and test changing Course Pacing among the two options
  • After changing the Course Pacing go to the outline, click the three dots of a subsection, click in Configure and then in Visibility
  • You should watch:
# `Course Pacing` equal to `Self-Paced`
`Hide content after end date
After the course's end date has passed, learners can no longer access its content. The subsection is not included in grade calculations.`

# `Course Pacing` equal to `Instructor-Paced`
`Hide content after due date
After the subsection's due date has passed, learners can no longer access its content. The subsection is not included in grade calculations.`

Screenshots

instructor_paced
self-paced

@openedx-webhooks
Copy link

Thanks for the pull request, @bra-i-am!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (59243b0) to head (626d469).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
+ Coverage   93.30%   93.33%   +0.02%     
==========================================
  Files        1101     1107       +6     
  Lines       21856    22006     +150     
  Branches     4741     4755      +14     
==========================================
+ Hits        20393    20539     +146     
- Misses       1392     1396       +4     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

2 participants