Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): translate files and videos table view #1591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(i18n): translate files and videos table view #1591

wants to merge 1 commit into from

Conversation

igobranco
Copy link

Description

Fix translation issue on Files and Videos table view mode on the columns.

Screen capture From Open edX Sandbox.
URL: https://apps.sandbox.openedx.org/course-authoring/course/course-v1:OpenedX+IS+2025_T1/assets:
English:
image

Portuguese (Portugal) pt-pt locale, the table header isn't translated:
image

With this fix:
image

Testing instructions

Need to pull translations, example just for pt_PT locale.

make OPENEDX_ATLAS_PULL=true ATLAS_OPTIONS="--filter=pt_PT" pull_translations

Append the new translations on for example for pt_PT locale (file: src/i18n/messages/frontend-app-course-authoring/pt_PT.json):

{
...
  "course-authoring.files-and-uploads.file-info.fileName.column": "Nome do ficheiro",
  "course-authoring.files-and-uploads.file-info.fileSize.column": "Tamanho do ficheiro",
  "course-authoring.files-and-uploads.file-info.fileType.column": "Tipo de ficheiro",
  "course-authoring.files-and-uploads.file-info.fileActive.column": "Ativo",
  "course-authoring.files-and-uploads.file-info.fileAccess.column": "Acesso",
...
}

Then view the course authoring MFE using that other locale. Example change openedx-language-preference cookie value on your browser to pt-pt.

@igobranco igobranco requested a review from a team as a code owner January 14, 2025 16:40
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 14, 2025 •
edited
Loading

Thanks for the pull request, @igobranco!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 15, 2025
@igobranco igobranco force-pushed the igobranco/translate-files-table branch from 96f091a to 80b66ec Compare January 24, 2025 11:45
@igobranco igobranco force-pushed the igobranco/translate-files-table branch from 80b66ec to 8dba735 Compare January 24, 2025 11:50
@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (8385c4e) to head (8dba735).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
+ Coverage   93.07%   93.24%   +0.17%     
==========================================
  Files        1092     1100       +8     
  Lines       21617    21795     +178     
  Branches     4577     4703     +126     
==========================================
+ Hits        20120    20323     +203     
+ Misses       1431     1400      -31     
- Partials       66       72       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 29, 2025
@mphilbrick211
Copy link

This is ready for review, @openedx/2u-tnl. Thanks!

@ChrisChV ChrisChV self-requested a review February 6, 2025 00:00
ChrisChV
ChrisChV requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I commented some nits on the message descriptions

src/files-and-videos/files-page/messages.js
fileNameColumn: {
id: 'course-authoring.files-and-uploads.file-info.fileName.column',
defaultMessage: 'File name',
description: 'Column name of the file name list view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
description: 'Column name of the file name list view',
description: 'Title of the File Name column in the file list view',

src/files-and-videos/files-page/messages.js
fileSizeColumn: {
id: 'course-authoring.files-and-uploads.file-info.fileSize.column',
defaultMessage: 'File size',
description: 'Column name of the file size list view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
description: 'Column name of the file size list view',
description: 'Title of the File size column in the file list view',

src/files-and-videos/files-page/messages.js
fileTypeColumn: {
id: 'course-authoring.files-and-uploads.file-info.fileType.column',
defaultMessage: 'Type',
description: 'Column name of the file type list view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
description: 'Column name of the file type list view',
description: 'Title of the Type column in the file list view',

src/files-and-videos/files-page/messages.js
fileActiveColumn: {
id: 'course-authoring.files-and-uploads.file-info.fileActive.column',
defaultMessage: 'Active',
description: 'Column name of the file active status list view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
description: 'Column name of the file active status list view',
description: 'Title of the Active column in the file list view',

src/files-and-videos/files-page/messages.js
fileAccessColumn: {
id: 'course-authoring.files-and-uploads.file-info.fileAccess.column',
defaultMessage: 'Access',
description: 'Column name of the file access status list view',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

Suggested change
description: 'Column name of the file access status list view',
description: 'Title of the Access column in the file list view',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisChV ChrisChV ChrisChV requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igobranco @openedx-webhooks @mphilbrick211 @ChrisChV