feat: adds assignment flow #1627
Conversation
There was a problem hiding this comment.
Seeing some issues when
Orphaned highlight around button when navigating into budget
https://github.com/user-attachments/assets/d366a949-66e4-4817-a9c0-11d0b49a7de9
Not scrolling far enough when transitioning from step 6-7
https://github.com/user-attachments/assets/902b2acc-0afd-4b4d-b79c-4f39ab5e08c1
| export const ALLOCATE_LEARNING_BUDGETS_TARGETS = { | ||
| SIDEBAR: 'learner-credit-link', | ||
| VIEW_BUDGET: 'learner-credit-view-budget-button', | ||
| ASSIGNMENT_BUDGET_DETAIL_CARD: 'assignment-budget-detail-card', |
There was a problem hiding this comment.
I see this value hardcoded in a lot of places in the code, can we use the constant here?
| @@ -59,7 +88,14 @@ const AdminOnboardingTours: FC<AdminOnboardingToursProps> = ({ | |||
| if (adminOnboardingSteps[currentStep]) { | |||
| const nextTarget = adminOnboardingSteps[currentStep].target; | |||
| const targetWithoutPrefix = nextTarget.replace(/^[.#]/, ''); | |||
| setTarget(targetWithoutPrefix); | |||
| // Add timeout for assignment-budget-detail-card to wait for page loading | |||
| if (targetWithoutPrefix === 'assignment-budget-detail-card') { | |||
There was a problem hiding this comment.
Is there a more responsive and reusable way we could do this, if we really need to wait for elements to load before making the switch? Especially since we're doing the same wait in CheckpointOverlay.
katrinan029
force-pushed
the
knguyen2/ent-10521
branch
from
b3d672c to
e3ccd74
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
- Coverage 86.82% 86.78% -0.05%
==========================================
Files 779 780 +1
Lines 17634 17683 +49
Branches 3670 3694 +24
==========================================
+ Hits 15311 15346 +35
- Misses 2247 2270 +23
+ Partials 76 67 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For all changes
https://2u-internal.atlassian.net/browse/ENT-10521
Screen.Recording.2025-07-23.at.11.14.28.PM.mov
Only if submitting a visual change