Skip to content

feat: Support filtering on activity tab for action status #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Jul 22, 2025

  • Remove getLastActionStatus function, use API values directly
  • Fix errorReason field access after camelCase transformation
  • Add nested field filtering/sorting (action_status, action_error_reason)
  • Implement configuration-driven filtering for maintainability
  • Update status mappings (reminded vs waiting_for_learner)
  • Fix BnrRequestStatusCell error display (failed_approval → "Failed: Approval")
  • Add React.memo optimizations and fix deprecation warnings
  • Update tests for new API structure

Maintains backward compatibility while enabling enhanced filtering capabilities.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

…ring

- Remove getLastActionStatus function, use API values directly
- Fix errorReason field access after camelCase transformation
- Add nested field filtering/sorting (action_status, action_error_reason)
- Implement configuration-driven filtering for maintainability
- Update status mappings (reminded vs waiting_for_learner)
- Fix BnrRequestStatusCell error display (failed_approval → "Failed: Approval")
- Add React.memo optimizations and fix deprecation warnings
- Update tests for new API structure

Maintains backward compatibility while enabling enhanced filtering capabilities.
@zwidekalanga zwidekalanga force-pushed the feat/learner-credit-request-supporting-filtering branch from c26c034 to 5c99423 Compare July 22, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant