feat: migrate deprecated Table to DataTable for LearnerActivityTable #1453
+3,426
−3,094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
98c4a8f to
7bebdb2
Compare
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
7bebdb2 to
ebc5bb0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 87.48% 87.57% +0.09%
==========================================
Files 739 753 +14
Lines 16723 16940 +217
Branches 3515 3462 -53
==========================================
+ Hits 14630 14836 +206
- Misses 2019 2038 +19
+ Partials 74 66 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
3 times, most recently
from
b3fbea2 to
4e4d6a9
Compare
mahamakifdar19
approved these changes
Mar 24, 2025
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
4e4d6a9 to
7a67457
Compare
brobro10000
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Great job with implementation. I'd implore you to give the useDatatable hook an attempt with at least generating the necessary datastructures for sorting an filtering to be parsed by an API outside of useDatatable.
Some nits related to testing and implementation.
src/components/LearnerActivityTable/LearnerActivityTable.test.jsx
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
src/components/LearnerActivityTable/data/hooks/useCourseEnrollments.js
Outdated
Show resolved
Hide resolved
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
7a67457 to
7300e52
Compare
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
4 times, most recently
from
326757d to
15ba6d5
Compare
brobro10000
approved these changes
Mar 27, 2025
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
15ba6d5 to
9b5f4c8
Compare
jajjibhai008
force-pushed
the
eahmadjaved/ENT-10165-2
branch
2 times, most recently
from
7d42f1e to
2bc7cfc
Compare
mahamakifdar19
force-pushed
the
eahmadjaved/ENT-10165-2
branch
4 times, most recently
from
935f75b to
5cdbd2d
Compare
mahamakifdar19
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
f188ad9 to
5f500d1
Compare
irfanuddinahmad
changed the title
irfanuddinahmad
force-pushed
the
eahmadjaved/ENT-10165-2
branch
2 times, most recently
from
d58f8d7 to
8e6c5f9
Compare
* fix: fix pagination issue for learner activity table * fix: added autoResetPage option for DataTable --------- Co-authored-by: irfanuddinahmad <[email protected]>
irfanuddinahmad
force-pushed
the
eahmadjaved/ENT-10165-2
branch
from
8e6c5f9 to
fd46145
Compare
fix: datatable data fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is the short recording after replacing the table.
Screen.Recording.2025-03-20.at.6.09.06.PM.mov
JIRA- ENT-10165
For all changes
Only if submitting a visual change