Skip to content

fix: update datatable fields for select all bug #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brobro10000
Copy link
Member

@brobro10000 brobro10000 commented Mar 13, 2025

In the current state of Datatable components with the isSelectable attribute enabled along with attribute SelectionStatusComponent={DataTable.ControlledSelectionStatus} there is a bug that when a table is filtered, all the items of the filtered component is selected, and the filter removed, the table selects all components from the unfiltered state despite only being selected in the filtered state.

This is due to the field isEntireTableSelected being set to true when a datatable is filtered and all fields are selected in the filtered state, but retains that value after removing the filter. On the Paragon documentation site, this is not indicative of default behavior, where isEntireTableSelected returns to false after removing the filter.

Screen.Recording.2025-03-13.at.10.48.43.AM.mov

Note: Some formatting of the imports may have occured due to my IDEs habit of alphabetizing multiple imports on files modified or visited

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (9efae9f) to head (4b8b2fe).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   86.83%   86.85%   +0.02%     
==========================================
  Files         667      667              
  Lines       15142    15174      +32     
  Branches     3144     3207      +63     
==========================================
+ Hits        13148    13180      +32     
+ Misses       1929     1921       -8     
- Partials       65       73       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant