Added % sign to 2 columns that contain percentage values. #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saleem-latif
requested review from
muhammad-ammar,
jajjibhai008 and
mahamakifdar19
| @@ -121,7 +121,9 @@ const ModuleActivityReport = ({ enterpriseId }) => { | |||
| defaultMessage: '% Activities Complete', | |||
| description: 'Header for the percentage of activities completed column in the module activity report table', | |||
| }), | |||
| accessor: 'percentage_completed_activities', | |||
| Cell: ({ row }) => ( | |||
| `${row.original.percentage_completed_activities} %` | |||
There was a problem hiding this comment.
Shouldn't we also apply the isNumber check here before appending %?
There was a problem hiding this comment.
Nope, this one is being sent by the server in string form so isNumber always returns false.
mahamakifdar19
approved these changes
Feb 26, 2025
saleem-latif
force-pushed
the
saleem-latif/ENT-10021-update
branch
from
0fa78d6 to
28214a1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1435 +/- ##
==========================================
- Coverage 86.42% 86.41% -0.02%
==========================================
Files 660 660
Lines 14932 14934 +2
Branches 3162 3168 +6
==========================================
Hits 12905 12905
- Misses 1957 1959 +2
Partials 70 70 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to push a commit as part of #1434 details are on that PR.
For all changes
Only if submitting a visual change