Clear all ProctoredExamSoftwareSecureReviewHistory instances of PII #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the time at which we read instances of the ProctoredExamSoftwareSecureReviewHistory model. This is necessary because the act of saving the ProctoredExamSoftwareSecureReview model causes the pre-save instance to be saved to the ProctoredExamSoftwareSecureReviewHistory table. Because we read instances of the ProctoredExamSoftwareSecureReviewHistory model prior to calling save on the instances of the ProctoredExamSoftwareSecureReview model, we do not have the full queryset we need. Reading the instances of the ProctoredExamSoftwareSecureReviewHistory model from the database after we clear all the instances of the ProctoredExamSoftwareSecureReview model fixes this issue.
rijuma
approved these changes
Feb 10, 2025
|
Javascript tests are failing due to an issue launching the PhantomJS browser. I've logged #1264 for this issue. I'm merging this pull request regardless because pull request did not cause this issue. |
michaelroytman
deleted the
michaelroytman/COSMO-595-update-retirement-coverage-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request changes the time at which we read instances of the
ProctoredExamSoftwareSecureReviewHistorymodel. This is necessary because the act of saving theProctoredExamSoftwareSecureReviewmodel causes the pre-save instance to be saved to theProctoredExamSoftwareSecureReviewHistorytable. Because we read instances of theProctoredExamSoftwareSecureReviewHistorymodel prior to calling save on the instances of theProctoredExamSoftwareSecureReviewmodel, we do not have the full queryset we need. Reading the instances of theProctoredExamSoftwareSecureReviewHistorymodel from the database after we clear all the instances of theProctoredExamSoftwareSecureReviewmodel fixes this issue.JIRA:
COSMO-595 (private)
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: