Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Software Secure review, history, and comment models to retirement endpoint. #1262

Merged

Conversation

MichaelRoytman
Copy link
Contributor

@MichaelRoytman MichaelRoytman commented Feb 3, 2025

Description:

This pull request adds the ProctoredExamSoftwareSecureReview, ProctoredExamSoftwareSecureReviewHistory, and ProctoredExamSoftwareSecureComment models to retirement endpoint.

JIRA:

COSMO-595 (private)

Pre-Merge Checklist:

  • Updated the version number in edx_proctoring/__init__.py and package.json if these changes are to be released.
  • Described your changes in CHANGELOG.rst
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

@MichaelRoytman MichaelRoytman force-pushed the michaelroytman/COSMO-595-update-retirement-coverage branch 3 times, most recently from f83f40a to 42f7411 Compare February 4, 2025 18:50
Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@rijuma rijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelRoytman MichaelRoytman force-pushed the michaelroytman/COSMO-595-update-retirement-coverage branch from 42f7411 to 2333e39 Compare February 5, 2025 17:10
@MichaelRoytman
Copy link
Contributor Author

Javascript tests are failing due to an issue launching the PhantomJS browser. I've logged #1264 for this issue.

I'm merging this pull request regardless because pull request did not cause this issue.

@MichaelRoytman MichaelRoytman merged commit ebee8a3 into master Feb 6, 2025
20 of 22 checks passed
@MichaelRoytman MichaelRoytman deleted the michaelroytman/COSMO-595-update-retirement-coverage branch February 6, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants