-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exam submit email content #1261
fix: exam submit email content #1261
Conversation
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
48b9535
to
b7afdad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text changes look good, thank you.
If we're bumping the version to 5.1.0 shouldn't we add a note to the changelog?
edx_proctoring/__init__.py
Outdated
@@ -3,4 +3,4 @@ | |||
""" | |||
|
|||
# Be sure to update the version number in edx_proctoring/package.json | |||
__version__ = '5.0.1' | |||
__version__ = '5.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a minor change so a patch version upgrade should be enough for this.
Bumping the version to 5.0.2
should suffice.
__version__ = '5.1.0' | |
__version__ = '5.0.2' |
package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "@edx/edx-proctoring", | |||
"//": "Note that the version format is slightly different than that of the Python version when using prereleases.", | |||
"version": "5.0.1", | |||
"version": "5.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A patch version upgrade should be enough for this change.
"version": "5.1.0", | |
"version": "5.0.2", |
b7afdad
to
1212f9b
Compare
@Anas12091101 it looks like there's one failing test check. |
@e0d the error in the check is coming on other PRs as well. Maybe this could help: karma-runner/karma#1270 (comment) |
c8fac85
to
dbb3f79
Compare
Description:
This PR modifies the exam submit email message to avoid confusion among the learners.
Issues:
https://github.com/mitodl/hq/issues/708
https://github.com/mitodl/hq/issues/720
Pre-Merge Checklist:
edx_proctoring/__init__.py
andpackage.json
if these changes are to be released.CHANGELOG.rst
Post-Merge: