Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exam submit email content #1261

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

Anas12091101
Copy link
Contributor

@Anas12091101 Anas12091101 commented Jan 30, 2025

Description:

This PR modifies the exam submit email message to avoid confusion among the learners.

Issues:

https://github.com/mitodl/hq/issues/708
https://github.com/mitodl/hq/issues/720

Pre-Merge Checklist:

  • Updated the version number in edx_proctoring/__init__.py and package.json if these changes are to be released.
  • Described your changes in CHANGELOG.rst
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

@openedx-webhooks
Copy link

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @openedx/openedx-unmaintained.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 30, 2025
@Anas12091101 Anas12091101 force-pushed the anas/change-exam-submit-msg branch from 48b9535 to b7afdad Compare January 30, 2025 12:55
Copy link

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text changes look good, thank you.

If we're bumping the version to 5.1.0 shouldn't we add a note to the changelog?

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 6, 2025
@@ -3,4 +3,4 @@
"""

# Be sure to update the version number in edx_proctoring/package.json
__version__ = '5.0.1'
__version__ = '5.1.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a minor change so a patch version upgrade should be enough for this.
Bumping the version to 5.0.2 should suffice.

Suggested change
__version__ = '5.1.0'
__version__ = '5.0.2'

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "@edx/edx-proctoring",
"//": "Note that the version format is slightly different than that of the Python version when using prereleases.",
"version": "5.0.1",
"version": "5.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A patch version upgrade should be enough for this change.

Suggested change
"version": "5.1.0",
"version": "5.0.2",

@Anas12091101 Anas12091101 force-pushed the anas/change-exam-submit-msg branch from b7afdad to 1212f9b Compare February 7, 2025 08:02
@e0d
Copy link

e0d commented Feb 7, 2025

@Anas12091101 it looks like there's one failing test check.

@Anas12091101
Copy link
Contributor Author

Anas12091101 commented Feb 10, 2025

@e0d the error in the check is coming on other PRs as well. Maybe this could help: karma-runner/karma#1270 (comment)

@Anas12091101 Anas12091101 force-pushed the anas/change-exam-submit-msg branch from c8fac85 to dbb3f79 Compare February 10, 2025 14:28
@michaelroytman michaelroytman merged commit 65203a0 into openedx:master Feb 10, 2025
20 of 22 checks passed
@openedx-webhooks openedx-webhooks removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants