Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible fix for red herring error #1194

Closed
wants to merge 2 commits into from
Closed

fix: possible fix for red herring error #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df4c4f3
fix: possible fix for red herring error
ilee2u Mar 12, 2024
447f3a6
fix: filter lti_external in get_backend_provider
ilee2u Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions edx_proctoring/backends/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,10 @@
return None
if exam['backend']:
name = exam['backend']
if name == 'lti_external':
# `get_backend_provider()` is called in many places in edx-proctoring, so this filter for
# LTI providers needs to be in this function. Not sure if this is the exact right place
# Also not sure what I should return here
return None

Check warning on line 24 in edx_proctoring/backends/__init__.py

View check run for this annotation

Codecov / codecov/patch

edx_proctoring/backends/__init__.py#L24 

Added line #L24 was not covered by tests
return apps.get_app_config('edx_proctoring').get_backend(name=name)

Loading