Skip to content

Commit

Permalink
chore: fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
nsprenkle committed Sep 12, 2023
1 parent f697ff2 commit 1f8ffe3
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 11 deletions.
4 changes: 2 additions & 2 deletions openassessment/xblock/apis/assessments/self_assessment_api.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from openassessment.assessment.api import self as self_api
from submissions import api as submission_api

from openassessment.xblock.utils.data_conversion import create_submission_dict
from openassessment.assessment.api import self as self_api
from openassessment.xblock.apis.step_data_api import StepDataAPI
from openassessment.xblock.utils.data_conversion import create_submission_dict


class SelfAssessmentAPI(StepDataAPI):
Expand Down
21 changes: 14 additions & 7 deletions openassessment/xblock/apis/assessments/staff_assessment_api.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
from openassessment.assessment.api import staff as staff_api, teams as teams_api
from submissions import team_api as team_sub_api

from openassessment.assessment.api import staff as staff_api, teams as teams_api
from openassessment.xblock.apis.step_data_api import StepDataAPI
from openassessment.xblock.utils.data_conversion import (
clean_criterion_feedback,
create_rubric_dict,
)
from openassessment.xblock.apis.step_data_api import StepDataAPI


class StaffAssessmentAPI(StepDataAPI):
@property
Expand All @@ -31,16 +30,22 @@ def student_id(self):

@property
def rubric_dict(self):
return create_rubric_dict(self.config_data.prompts, self.config_data.rubric_criteria_with_labels)
return create_rubric_dict(
self.config_data.prompts, self.config_data.rubric_criteria_with_labels
)

def create_team_assessment(self, data):
team_submission = team_sub_api.get_team_submission_from_individual_submission(data["submission_uuid"])
team_submission = team_sub_api.get_team_submission_from_individual_submission(
data["submission_uuid"]
)
return (
teams_api.create_assessment(
team_submission["team_submission_uuid"],
self.student_id,
data["options_selected"],
clean_criterion_feedback(self.config_data.rubric_criteria, data["criterion_feedback"]),
clean_criterion_feedback(
self.config_data.rubric_criteria, data["criterion_feedback"]
),
data["overall_feedback"],
self.rubric_dict,
),
Expand All @@ -52,7 +57,9 @@ def create_assessment(self, data):
data["submission_uuid"],
self.student_id,
data["options_selected"],
clean_criterion_feedback(self.config_data.rubric_criteria, data["criterion_feedback"]),
clean_criterion_feedback(
self.config_data.rubric_criteria, data["criterion_feedback"]
),
data["overall_feedback"],
self.rubric_dict,
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def failure_response(reason):
workflow_api.AssessmentWorkflowRequestError,
):
logger.warning(
"An error occurred while submitting a self assessment " "for the submission %s",
"An error occurred while submitting a self assessment for the submission %s",
submission_uuid,
exc_info=True,
)
Expand All @@ -67,7 +67,7 @@ def failure_response(reason):
workflow_api.AssessmentWorkflowInternalError,
):
logger.exception(
"An error occurred while submitting a self assessment " "for the submission %s",
"An error occurred while submitting a self assessment for the submission %s",
submission_uuid,
)
return failure_response(messages["could_not_submit"])
Expand Down

0 comments on commit 1f8ffe3

Please sign in to comment.