-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitor_django_management_command #482
Open
hamza-56
wants to merge
1
commit into
openedx:master
Choose a base branch
from
hamza-56:hamza/monitor-django-management-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+146
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
""" | ||
Tests monitoring utils. | ||
""" | ||
from unittest.mock import patch | ||
|
||
from django.test import TestCase, override_settings | ||
|
||
from edx_django_utils.monitoring import monitor_django_management_command | ||
|
||
|
||
class MonitorDjangoManagementCommandTests(TestCase): | ||
"""Test suite for monitor_django_management_command.""" | ||
|
||
@patch("edx_django_utils.monitoring.internal.utils.function_trace") | ||
@patch("edx_django_utils.monitoring.internal.utils.set_monitoring_transaction_name") | ||
def test_monitoring_enabled(self, mock_set_transaction_name, mock_function_trace): | ||
""" | ||
Test that when custom management command monitoring is enabled: | ||
- function_trace is called with the correct trace name. | ||
- set_monitoring_transaction_name is called with the correct command name. | ||
""" | ||
|
||
with override_settings(ENABLE_CUSTOM_MANAGEMENT_COMMAND_MONITORING=True): | ||
with monitor_django_management_command("test_command"): | ||
pass | ||
|
||
mock_function_trace.assert_called_once_with("django.command") | ||
mock_set_transaction_name.assert_called_once_with("test_command") | ||
|
||
@patch("edx_django_utils.monitoring.internal.utils.function_trace") | ||
@patch("edx_django_utils.monitoring.internal.utils.set_monitoring_transaction_name") | ||
def test_monitoring_disabled(self, mock_set_transaction_name, mock_function_trace): | ||
""" | ||
Test that when custom management command monitoring is disabled: | ||
- function_trace and set_monitoring_transaction_name are not called. | ||
""" | ||
|
||
with override_settings(ENABLE_CUSTOM_MANAGEMENT_COMMAND_MONITORING=False): | ||
with monitor_django_management_command("test_command"): | ||
pass | ||
|
||
mock_function_trace.assert_not_called() | ||
mock_set_transaction_name.assert_not_called() | ||
|
||
@patch("edx_django_utils.monitoring.internal.utils.function_trace") | ||
@patch("edx_django_utils.monitoring.internal.utils.set_monitoring_transaction_name") | ||
def test_custom_trace_name_usage(self, mock_set_name, mock_function_trace): | ||
""" | ||
Test that a custom trace name is used when DJANGO_MANAGEMENT_MONITORING_FUNCTION_TRACE_NAME | ||
is explicitly set. | ||
""" | ||
|
||
with override_settings( | ||
ENABLE_CUSTOM_MANAGEMENT_COMMAND_MONITORING=True, | ||
DJANGO_MANAGEMENT_MONITORING_FUNCTION_TRACE_NAME="custom.trace", | ||
): | ||
with monitor_django_management_command("test_command"): | ||
pass | ||
|
||
mock_function_trace.assert_called_once_with("custom.trace") | ||
mock_set_name.assert_called_once_with("test_command") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a scenario where
len(sys.argv) > 1
, and would you really want to drop monitoring altogether, or would you want to just pass a different (static) value tomonitor_django_management_command
?