Skip to content

feat: use current timestamp for Credly badge issuance date - #3001

Open
luisfelipec95 wants to merge 1 commit into
openedx:masterfrom
Pearson-Advance:lfc/credly-badge-issued-at-date
Open

feat: use current timestamp for Credly badge issuance date#3001
luisfelipec95 wants to merge 1 commit into
openedx:masterfrom
Pearson-Advance:lfc/credly-badge-issued-at-date

Conversation

@luisfelipec95

Copy link
Copy Markdown
Contributor

Description

Updates the issued_at timestamp sent to Credly when issuing a badge.

Previously, issued_at was set to badge_template.created (the creation date of the badge template). This caused badges to be backdated to when the template was created rather than showing the date when the badge was actually awarded to the user.

Testing Instructions

  1. Award a Credly badge to a user where the badge template was created in the past.
  2. Check the issued badge details on Credly to confirm Issued on matches the current timestamp instead of the template creation date.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @luisfelipec95!

This repository is currently maintained by @jajjibhai008.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: No status
Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants