Skip to content

Add a template for release tracker issue #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2025

Conversation

AjayJagan
Copy link
Member

@AjayJagan AjayJagan commented Feb 27, 2025

Description

The creation of release tracker is a repetitive process every release. So adding a template to make it easy.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@AjayJagan
Copy link
Member Author

@zdtsw ^

attributes:
label: "📅 Planned Release Date"
description: "Enter the planned release date (e.g., Mar 21st, 2025)"
placeholder: "Mar 21st, 2025"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need placeholder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are grayed out fields which are overwritten when we enter a value, so I thought it will serve as an example

attributes:
label: "🛑 Manifest Update Deadline"
description: "Enter the last date for updating manifests (e.g., Mar 14th, 2025)"
placeholder: "Mar 14th, 2025"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, why need placeholder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess we need update this to monday?
14th march is a friday

set to 30th June 2025 as code freeze ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is true. I will update them to have a valid Monday 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is Sunday (8th June as code freeze) and Monday (9th June release ODH)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 my bad I was thinking today as tuesday

id: release_date
attributes:
label: "📅 Planned Release Date"
description: "Enter the planned release date (e.g., Mar 21st, 2025)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand this.
we set code freeze day for component teams to submit their changes with certain date, normally on a friday
then the next Monday is the planned release date.
what is Manifests update deadline and planned release date mean here?

e.g odh 2.26.0 has code freeze on 14th March 2025, and release date on 17th March 2025.
how this example 21th March 2025 come in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right
Manifests update deadline = code freeze
planned release date = the Monday we do the release
And my mistake it should be 17th. changing now

Copy link
Member

@zdtsw zdtsw Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway i think we need to be more clear
code freeze is code freeze, stick with the general term, not try to invent new name "manifests udpate deadline"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let me update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done now 👍

Signed-off-by: AJAY JAGANATHAN <[email protected]>
Signed-off-by: AJAY JAGANATHAN <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 27, 2025
@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2025
@zdtsw
Copy link
Member

zdtsw commented Feb 27, 2025

/approve

@AjayJagan
Copy link
Member Author

maybe needs a manual merge? 🤔

@openshift-ci openshift-ci bot removed the lgtm label Jun 9, 2025
@openshift-ci openshift-ci bot added the lgtm label Jun 9, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jun 9, 2025
@openshift-ci openshift-ci bot added the lgtm label Jun 9, 2025
@zdtsw
Copy link
Member

zdtsw commented Jun 9, 2025

@accorvin / @jkoehler-redhat if you are the admins, can you merge this PR ?

Copy link
Member

@anishasthana anishasthana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@accorvin
Copy link
Member

accorvin commented Jun 9, 2025

/approve

Copy link

openshift-ci bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: accorvin, AjayJagan, anishasthana, zdtsw

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Member

zdtsw commented Jun 10, 2025

I guess we need someone with permission manually merge this PR

@accorvin accorvin merged commit 8429035 into opendatahub-io:main Jun 10, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants